[SPARK-33696][BUILD][SQL] Upgrade built-in Hive to 2.3.8 #30657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yey! |
viirya
reviewed
Dec 8, 2020
| @@ -102,7 +102,7 @@ package object client { | |||
|
|
|||
| // Since HIVE-14496, Hive materialized view need calcite-core. | |||
| // For spark, only VersionsSuite currently creates a hive materialized view for testing. | |||
| case object v2_3 extends HiveVersion("2.3.7", | |||
| case object v2_3 extends HiveVersion("2.3.8", | |||
There was a problem hiding this comment.
Per the test internally, this needs to be changed to pass all tests. But let's see the Jenkins result first.
|
Test build #132389 has finished for PR 30657 at commit
|
|
Yea, this was we encountered in internal test. So as #30657 (comment), there must be a separated |
|
@viirya @sunchao Can you reproduce this issue? Hadoop 2.7.7 + Hive 2.3.8: |
|
Hmm yes I used to see this failure in Hive UTs but I think it should have been resolved via apache/hive#1356, since we also shade calcite in |
|
let me try to reproduce this as well locally. |
|
@wangyum @viirya yes I was able to reproduce the same issue. I think it could be cause we have I'll update the release vote email thread and start a new RC once this is fixed. |
|
Thank you @sunchao . |
We have included Do we know where it comes from? |
|
@viirya yes exactly - it is from |
|
for comparison, the binary distribution from Hive master branch doesn't include any calcite jars, but I'm seeing: in 2.3.8 binary distribution. |
I only see |
|
I think we need something like https://issues.apache.org/jira/browse/HIVE-23593 and exclude calcite from |
|
retest this please. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #132524 has finished for PR 30657 at commit
|
|
Kubernetes integration test starting |
| "org.apache.calcite.avatica:avatica", | ||
| "com.google.guava:guava", |
There was a problem hiding this comment.
Just curious. Why do we need to exclude it? Hive 2.3.8 is supposed to shade it, isn't it?
|
Kubernetes integration test status failure |
|
Test build #132549 has finished for PR 30657 at commit
|
|
@sunchao @viirya Could we do not include
Hive 2.3.8 load class from Hive 2.3.7 load class from |
wangyum
commented
Jan 8, 2021
Comment on lines
+1858
to
+1873
| <exclusion> | ||
| <groupId>net.hydromatic</groupId> | ||
| <artifactId>eigenbase-properties</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.codehaus.janino</groupId> | ||
| <artifactId>commons-compiler</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.codehaus.janino</groupId> | ||
| <artifactId>janino</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.pentaho</groupId> | ||
| <artifactId>pentaho-aggdesigner-algorithm</artifactId> | ||
| </exclusion> |
There was a problem hiding this comment.
These dependencies added by apache/hive@52a4ab8
|
Test build #133840 has finished for PR 30657 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #133861 has finished for PR 30657 at commit
|
# Conflicts: # dev/deps/spark-deps-hadoop-3.2-hive-2.3
|
Test build #134133 has finished for PR 30657 at commit
|
|
Retest this please |
|
Test build #134151 has finished for PR 30657 at commit
|
sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
Outdated
Show resolved
Hide resolved
|
Artifacts have been published to Maven now - could you try this again? |
|
retest this please. |
|
Great! Could you remove the |
wangyum
changed the title
|
Test build #134170 has finished for PR 30657 at commit
|
dongjoon-hyun
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @wangyum and all!
Merged to master for Apache Spark 3.2.0.
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
### What changes were proposed in this pull request? Hive 2.3.8 changes: HIVE-19662: Upgrade Avro to 1.8.2 HIVE-24324: Remove deprecated API usage from Avro HIVE-23980: Shade Guava from hive-exec in Hive 2.3 HIVE-24436: Fix Avro NULL_DEFAULT_VALUE compatibility issue HIVE-24512: Exclude calcite in packaging. HIVE-22708: Fix for HttpTransport to replace String.equals HIVE-24551: Hive should include transitive dependencies from calcite after shading it HIVE-24553: Exclude calcite from test-jar dependency of hive-exec ### Why are the changes needed? Upgrade Avro and Parquet to latest version. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing test add test try to upgrade Parquet to 1.11.1 and Avro to 1.10.1: apache#30517 Closes apache#30657 from wangyum/SPARK-33696. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This was referenced Apr 19, 2021
LorenzoMartini
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 19, 2021
Hive 2.3.8 changes: HIVE-19662: Upgrade Avro to 1.8.2 HIVE-24324: Remove deprecated API usage from Avro HIVE-23980: Shade Guava from hive-exec in Hive 2.3 HIVE-24436: Fix Avro NULL_DEFAULT_VALUE compatibility issue HIVE-24512: Exclude calcite in packaging. HIVE-22708: Fix for HttpTransport to replace String.equals HIVE-24551: Hive should include transitive dependencies from calcite after shading it HIVE-24553: Exclude calcite from test-jar dependency of hive-exec Upgrade Avro and Parquet to latest version. No. Existing test add test try to upgrade Parquet to 1.11.1 and Avro to 1.10.1: apache#30517 Closes apache#30657 from wangyum/SPARK-33696. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
LorenzoMartini
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 19, 2021
Hive 2.3.8 changes: HIVE-19662: Upgrade Avro to 1.8.2 HIVE-24324: Remove deprecated API usage from Avro HIVE-23980: Shade Guava from hive-exec in Hive 2.3 HIVE-24436: Fix Avro NULL_DEFAULT_VALUE compatibility issue HIVE-24512: Exclude calcite in packaging. HIVE-22708: Fix for HttpTransport to replace String.equals HIVE-24551: Hive should include transitive dependencies from calcite after shading it HIVE-24553: Exclude calcite from test-jar dependency of hive-exec Upgrade Avro and Parquet to latest version. No. Existing test add test try to upgrade Parquet to 1.11.1 and Avro to 1.10.1: apache#30517 Closes apache#30657 from wangyum/SPARK-33696. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
16pierre
pushed a commit
to 16pierre/spark
that referenced
this pull request
May 24, 2021
Hive 2.3.8 changes: HIVE-19662: Upgrade Avro to 1.8.2 HIVE-24324: Remove deprecated API usage from Avro HIVE-23980: Shade Guava from hive-exec in Hive 2.3 HIVE-24436: Fix Avro NULL_DEFAULT_VALUE compatibility issue HIVE-24512: Exclude calcite in packaging. HIVE-22708: Fix for HttpTransport to replace String.equals HIVE-24551: Hive should include transitive dependencies from calcite after shading it HIVE-24553: Exclude calcite from test-jar dependency of hive-exec Upgrade Avro and Parquet to latest version. No. Existing test add test try to upgrade Parquet to 1.11.1 and Avro to 1.10.1: apache#30517 Closes apache#30657 from wangyum/SPARK-33696. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hive 2.3.8 changes:
HIVE-19662: Upgrade Avro to 1.8.2
HIVE-24324: Remove deprecated API usage from Avro
HIVE-23980: Shade Guava from hive-exec in Hive 2.3
HIVE-24436: Fix Avro NULL_DEFAULT_VALUE compatibility issue
HIVE-24512: Exclude calcite in packaging.
HIVE-22708: Fix for HttpTransport to replace String.equals
HIVE-24551: Hive should include transitive dependencies from calcite after shading it
HIVE-24553: Exclude calcite from test-jar dependency of hive-exec
Why are the changes needed?
Upgrade Avro and Parquet to latest version.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test add test try to upgrade Parquet to 1.11.1 and Avro to 1.10.1: #30517