[MINOR] Spelling sql/core #30531

jsoref · 2020-11-28T23:51:09Z

What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules:

sql/core

Split per @srowen #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Why are the changes needed?

Misspelled words make it harder to read / understand content.

Does this PR introduce any user-facing change?

There are various fixes to documentation, etc...

How was this patch tested?

No testing was performed

srowen · 2020-11-29T00:42:25Z

sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala

@@ -170,23 +170,23 @@ class DatasetPrimitiveSuite extends QueryTest with SharedSparkSession {
  test("groupBy function, map") {
    val ds = Seq(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11).toDS()
    val grouped = ds.groupByKey(_ % 2)
-    val agged = grouped.mapGroups { (g, iter) =>
+    val aggregated = grouped.mapGroups { (g, iter) =>


I don't feel strongly either way, but these don't necessarily need to be renamed. They're intentionally shorthand it seems. It might just reduce the number of lines touched.

.../src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala

srowen · 2020-12-02T14:51:19Z

I think this just needs a rebase, whenever prerequisite changes are in

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

srowen

Looks OK if tests pass

srowen · 2020-12-07T15:22:54Z

Jenkins retest this please

SparkQA · 2020-12-07T16:28:12Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36979/

SparkQA · 2020-12-07T16:57:26Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36979/

SparkQA · 2020-12-07T20:00:36Z

Test build #132379 has finished for PR 30531 at commit db599a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2020-12-08T14:48:38Z

Merged to master. @jsoref are there other PRs besides the main one left now?

jsoref · 2020-12-08T15:18:53Z

Nope. I'll refresh and split that one today.

dongjoon-hyun · 2020-12-22T19:43:05Z

Hi, @srowen and @jsoref . I'll also merge this minor patch to branch-3.1 to reduce merge conflicts.

cc @HyukjinKwon

dongjoon-hyun · 2020-12-22T19:45:54Z

I locally finished compilation tests and pushed.

### What changes were proposed in this pull request? This PR intends to fix typos in the sub-modules: * `sql/core` Split per srowen #30323 (comment) NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356 ### Why are the changes needed? Misspelled words make it harder to read / understand content. ### Does this PR introduce _any_ user-facing change? There are various fixes to documentation, etc... ### How was this patch tested? No testing was performed Closes #30531 from jsoref/spelling-sql-core. Authored-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Sean Owen <srowen@gmail.com> (cherry picked from commit a093d6f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>

github-actions bot added PYTHON SQL STRUCTURED STREAMING WEB UI labels Nov 28, 2020

jsoref mentioned this pull request Nov 28, 2020

Spelling #30323

Closed

srowen reviewed Nov 29, 2020

View reviewed changes

srowen changed the title ~~Spelling sql/core~~ [MINOR] Spelling sql/core Nov 29, 2020

jsoref force-pushed the spelling-sql-core branch from f6ff7bd to e42315a Compare November 29, 2020 01:11

jsoref added 21 commits December 7, 2020 10:06

spelling: adaptive

a39214b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: aggregated

0984351

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: available

9c55a27

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: batches

ef107be

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: bottom

b1db4b2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: calendar

eade260

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: captures

a53c5b5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: catalog

23a0c19

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: characters

be4a9d6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: checkpoint

d76a947

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: codegened

912a325

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: columnar

42b0b76

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: common

a314466

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: description

354198f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: deterministic

3769101

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: distinct

612fece

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: do not

11d3d70

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: doesn't

1fa7ac3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: don't

097946c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: e.g.

48e871e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: everything

94be7f1

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 17 commits December 7, 2020 10:08

spelling: replace

0bd9782

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: rolled up

8409f83

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: schema

1a59866

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: separator

ffd6c61

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: spark

e50bfb0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: stream

5456f86

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: subqueries

5478501

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: succeeded

69ba303

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: temporary

1013da5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: the

43da92e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: triggered

b412923

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unexpected

78f0ef0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unknown

da4faf8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: validate

40f97c8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: warning

4715490

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: whether

d3d6324

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

style: line length exceeds 100 characters

db599a5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref force-pushed the spelling-sql-core branch from e42315a to db599a5 Compare December 7, 2020 15:08

srowen approved these changes Dec 7, 2020

View reviewed changes

srowen closed this in a093d6f Dec 8, 2020

jsoref deleted the spelling-sql-core branch December 8, 2020 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MINOR] Spelling sql/core #30531

[MINOR] Spelling sql/core #30531

jsoref commented Nov 28, 2020

srowen Nov 29, 2020

srowen commented Dec 2, 2020

srowen left a comment

srowen commented Dec 7, 2020

SparkQA commented Dec 7, 2020

SparkQA commented Dec 7, 2020

SparkQA commented Dec 7, 2020

srowen commented Dec 8, 2020

jsoref commented Dec 8, 2020 •

edited

Loading

dongjoon-hyun commented Dec 22, 2020

dongjoon-hyun commented Dec 22, 2020

[MINOR] Spelling sql/core #30531

[MINOR] Spelling sql/core #30531

Conversation

jsoref commented Nov 28, 2020

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

srowen Nov 29, 2020

Choose a reason for hiding this comment

srowen commented Dec 2, 2020

srowen left a comment

Choose a reason for hiding this comment

srowen commented Dec 7, 2020

SparkQA commented Dec 7, 2020

SparkQA commented Dec 7, 2020

SparkQA commented Dec 7, 2020

srowen commented Dec 8, 2020

jsoref commented Dec 8, 2020 • edited Loading

dongjoon-hyun commented Dec 22, 2020

dongjoon-hyun commented Dec 22, 2020

jsoref commented Dec 8, 2020 •

edited

Loading