Skip to content

[SPARK-4141] Hide Accumulators column on stage page when no accumulators exist #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-4141] Hide Accumulators column on stage page when no accumulators exist #3031

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb72156
mimic hasInput. The basics work here, but wanna clean this up with m…
mmm Oct 30, 2014
c28c449
looking much better now... minimal explicit formatting. Now, see if …
mmm Oct 31, 2014
390893b
cleanup
mmm Oct 31, 2014
6141cb3
reformat to satisfy scalastyle linelength. build failed from jenkins…
mmm Oct 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {

val numCompleted = tasks.count(_.taskInfo.finished)
val accumulables = listener.stageIdToData((stageId, stageAttemptId)).accumulables
val hasAccumulators = accumulables.size > 0
val hasInput = stageData.inputBytes > 0
val hasShuffleRead = stageData.shuffleReadBytes > 0
val hasShuffleWrite = stageData.shuffleWriteBytes > 0
Expand Down Expand Up @@ -104,15 +105,18 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
val taskHeaders: Seq[String] =
Seq(
"Index", "ID", "Attempt", "Status", "Locality Level", "Executor ID / Host",
"Launch Time", "Duration", "GC Time", "Accumulators") ++
"Launch Time", "Duration", "GC Time") ++
{if (hasAccumulators) Seq("Accumulators") else Nil} ++
{if (hasInput) Seq("Input") else Nil} ++
{if (hasShuffleRead) Seq("Shuffle Read") else Nil} ++
{if (hasShuffleWrite) Seq("Write Time", "Shuffle Write") else Nil} ++
{if (hasBytesSpilled) Seq("Shuffle Spill (Memory)", "Shuffle Spill (Disk)") else Nil} ++
Seq("Errors")

val taskTable = UIUtils.listingTable(
taskHeaders, taskRow(hasInput, hasShuffleRead, hasShuffleWrite, hasBytesSpilled), tasks)
taskHeaders,
taskRow(hasAccumulators, hasInput, hasShuffleRead, hasShuffleWrite, hasBytesSpilled),
tasks)

// Excludes tasks which failed and have incomplete metrics
val validTasks = tasks.filter(t => t.taskInfo.status == "SUCCESS" && t.taskMetrics.isDefined)
Expand Down Expand Up @@ -232,6 +236,7 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
}

def taskRow(
hasAccumulators: Boolean,
hasInput: Boolean,
hasShuffleRead: Boolean,
hasShuffleWrite: Boolean,
Expand All @@ -244,6 +249,9 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
val gcTime = metrics.map(_.jvmGCTime).getOrElse(0L)
val serializationTime = metrics.map(_.resultSerializationTime).getOrElse(0L)

val maybeAccumulators = info.accumulables
val accumulatorsReadable = maybeAccumulators.map{acc => s"${acc.name}: ${acc.update.get}"}

val maybeInput = metrics.flatMap(_.inputMetrics)
val inputSortable = maybeInput.map(_.bytesRead.toString).getOrElse("")
val inputReadable = maybeInput
Expand Down Expand Up @@ -290,17 +298,17 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage") {
<td sorttable_customkey={gcTime.toString}>
{if (gcTime > 0) UIUtils.formatDuration(gcTime) else ""}
</td>
<td>
{Unparsed(
info.accumulables.map{acc => s"${acc.name}: ${acc.update.get}"}.mkString("<br/>")
)}
</td>
<!--
TODO: Add this back after we add support to hide certain columns.
<td sorttable_customkey={serializationTime.toString}>
{if (serializationTime > 0) UIUtils.formatDuration(serializationTime) else ""}
</td>
-->
{if (hasAccumulators) {
<td>
{Unparsed(accumulatorsReadable.mkString("<br/>"))}
</td>
}}
{if (hasInput) {
<td sorttable_customkey={inputSortable}>
{inputReadable}
Expand Down