-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-32890][SQL] Pass all sql/hive
module UTs in Scala 2.13
#29760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @srowen , this pr fix all failed test cases in In this patch add
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me
@@ -129,7 +129,8 @@ class HiveSchemaInferenceSuite | |||
// properties out). | |||
assert(!externalCatalog.getTable(DATABASE, TEST_TABLE_NAME).schemaPreservesCase) | |||
val rawTable = client.getTable(DATABASE, TEST_TABLE_NAME) | |||
assert(rawTable.properties.filterKeys(_.startsWith(DATASOURCE_SCHEMA_PREFIX)) == Map.empty) | |||
assert( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just check isEmpty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address ce5c81b fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check isEmpty looks simpler
Jenkins test this please |
Test build #128712 has finished for PR 29760 at commit
|
Test build #128713 has finished for PR 29760 at commit
|
Test build #128732 has finished for PR 29760 at commit
|
Merged to master |
What changes were proposed in this pull request?
This pr fix failed cases in sql hive module in Scala 2.13 as follow:
After this patch all test passed in sql hive module in Scala 2.13.
Why are the changes needed?
We need to support a Scala 2.13 build.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Scala 2.12: Pass the Jenkins or GitHub Action
Scala 2.13: All tests passed.
Do the following:
Before
After