[SPARK-32747][R][TESTS] Deduplicate configuration set/unset in test_sparkSQL_arrow.R #29592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
Member
Author
|
cc @viirya, can you take a quick look when you're available? |
viirya
reviewed
Aug 31, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
retest this please |
Member
Author
|
Thank you @viirya. |
HyukjinKwon
force-pushed
the
SPARK-32747
branch
from
fc2d91e to
5c61cb8
Compare
|
Test build #128079 has finished for PR 29592 at commit
|
|
Test build #128083 has finished for PR 29592 at commit
|
HyukjinKwon
added a commit
that referenced
this pull request
Aug 31, 2020
…parkSQL_arrow.R ### What changes were proposed in this pull request? This PR proposes to deduplicate configuration set/unset in `test_sparkSQL_arrow.R`. Setting `spark.sql.execution.arrow.sparkr.enabled` can be globally done instead of doing it in each test case. ### Why are the changes needed? To duduplicate the codes. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? Manually ran the tests. Closes #29592 from HyukjinKwon/SPARK-32747. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 2491cf1) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
Author
|
Merged to master and branch-3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to deduplicate configuration set/unset in
test_sparkSQL_arrow.R.Setting
spark.sql.execution.arrow.sparkr.enabledcan be globally done instead of doing it in each test case.Why are the changes needed?
To duduplicate the codes.
Does this PR introduce any user-facing change?
No, dev-only
How was this patch tested?
Manually ran the tests.