[SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc#29315
Closed
xuanyuanking wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc#29315xuanyuanking wants to merge 3 commits intoapache:masterfrom
xuanyuanking wants to merge 3 commits intoapache:masterfrom
Conversation
xuanyuanking
changed the title
Member
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Jul 31, 2020
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
Contributor
|
do we have the same problem in the error message? |
Contributor
|
cc @HeartSaVioR |
Member
Author
|
https://github.com/apache/spark/pull/28707/files#diff-238c6b2f820f62c556f204788d684584R150 |
cloud-fan
reviewed
Jul 31, 2020
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
|
Test build #126880 has finished for PR 29315 at commit
|
Contributor
|
This just updates the config doc and we don't need to wait for the test. Thanks, merging to master! |
|
Test build #126883 has finished for PR 29315 at commit
|
Contributor
|
post +1. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address comment in #28707 (comment)
Why are the changes needed?
Hide the implementation details in the config doc.
Does this PR introduce any user-facing change?
Config doc change.
How was this patch tested?
Document only.