[SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff. #28430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #122171 has finished for PR 28430 at commit
|
|
Test build #122173 has finished for PR 28430 at commit
|
HyukjinKwon
approved these changes
May 4, 2020
HyukjinKwon
reviewed
May 4, 2020
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #122240 has finished for PR 28430 at commit
|
|
retest this please |
|
Test build #122257 has finished for PR 28430 at commit
|
|
retest this please |
|
Test build #122261 has finished for PR 28430 at commit
|
|
Merged to master and branc-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 5, 2020
… that easy to track the diff ### What changes were proposed in this pull request? This PR follows up #28194. As discussed at https://github.com/apache/spark/pull/28194/files#r418418796. This PR will improve `ExpressionsSchemaSuite` so that easy to track the diff. Although `ExpressionsSchemaSuite` at line https://github.com/apache/spark/blob/b7cde42b04b21c9bfee6535199cf385855c15853/sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala#L165 just want to compare the total size between expected output size and the newest output size, the scalatest framework will output the extra information contains all the content of expected output and newest output. This PR will try to avoid this issue. After this PR, the exception looks like below: ``` [info] - Check schemas for expression examples *** FAILED *** (7 seconds, 336 milliseconds) [info] 340 did not equal 341 Expected 332 blocks in result file but got 333. Try regenerate the result files. (ExpressionsSchemaSuite.scala:167) [info] org.scalatest.exceptions.TestFailedException: [info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:530) [info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:529) [info] at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1560) [info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:503) [info] at org.apache.spark.sql.ExpressionsSchemaSuite.$anonfun$new$1(ExpressionsSchemaSuite.scala:167) ``` ### Why are the changes needed? Make the exception more concise and clear. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? Jenkins test. Closes #28430 from beliefer/improve-expressions-schema-suite. Authored-by: beliefer <beliefer@163.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b949420) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
@HyukjinKwon Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows up #28194.
As discussed at https://github.com/apache/spark/pull/28194/files#r418418796.
This PR will improve
ExpressionsSchemaSuiteso that easy to track the diff.Although
ExpressionsSchemaSuiteat linespark/sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
Line 165 in b7cde42
just want to compare the total size between expected output size and the newest output size, the scalatest framework will output the extra information contains all the content of expected output and newest output.
This PR will try to avoid this issue.
After this PR, the exception looks like below:
Why are the changes needed?
Make the exception more concise and clear.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Jenkins test.