[SPARK-31484][Core][Flollowup] Use taskAttemptId in checkpoint filename #28289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngone51
approved these changes
Apr 22, 2020
|
Test build #121606 has finished for PR 28289 at commit
|
|
retest this please |
| @@ -199,8 +199,7 @@ private[spark] object ReliableCheckpointRDD extends Logging { | |||
|
|
|||
| val finalOutputName = ReliableCheckpointRDD.checkpointFileName(ctx.partitionId()) | |||
| val finalOutputPath = new Path(outputDir, finalOutputName) | |||
| val tempOutputPath = new Path(outputDir, | |||
| s".$finalOutputName-attempt-${ctx.stageAttemptNumber()}-${ctx.attemptNumber()}") | |||
| val tempOutputPath = new Path(outputDir, s".$finalOutputName-attempt-${ctx.taskAttemptId()}") | |||
There was a problem hiding this comment.
BTW, do we need -attempt-?
There was a problem hiding this comment.
private[spark] class TaskDescription(
val taskId: Long,
val attemptNumber: Int,
...
I believe taskAttempId is some kind of historic name in TaskContext.
dongjoon-hyun
approved these changes
Apr 22, 2020
HyukjinKwon
approved these changes
Apr 22, 2020
|
Test build #121612 has finished for PR 28289 at commit
|
cloud-fan
approved these changes
Apr 22, 2020
|
Merged to master. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As suggested by #28255 (comment), this patch proposes to use taskAttemptId in checkpoint filename, instead of stageAttemptNumber + attemptNumber.
Why are the changes needed?
To simplify checkpoint simplified and unique.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.