Skip to content

[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark #27885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-31129][SQL][Tests] Fix IntervalBenchmark and DateTimeBenchmark #27885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7759b80
[SPARK-31111][SQL][Tests][FOLLOWUP] Fix interval output issue in Inte…
yaooqinn Mar 12, 2020
4015c76
fix DateTimeBenchmark
yaooqinn Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
434 changes: 217 additions & 217 deletions sql/core/benchmarks/DateTimeBenchmark-jdk11-results.txt
View file
Open in desktop

Large diffs are not rendered by default.

434 changes: 217 additions & 217 deletions sql/core/benchmarks/DateTimeBenchmark-results.txt
View file
Open in desktop

Large diffs are not rendered by default.

52 changes: 26 additions & 26 deletions sql/core/benchmarks/IntervalBenchmark-jdk11-results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
OpenJDK 64-Bit Server VM 11.0.5+10-post-Ubuntu-0ubuntu1.118.04 on Linux 4.15.0-1044-aws
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
prepare string w/ interval 756 831 78 1.3 756.4 1.0X
prepare string w/o interval 622 637 15 1.6 622.4 1.2X
1 units w/ interval 506 532 22 2.0 506.2 1.5X
1 units w/o interval 472 477 9 2.1 471.6 1.6X
2 units w/ interval 699 710 11 1.4 698.5 1.1X
2 units w/o interval 670 674 6 1.5 669.9 1.1X
3 units w/ interval 1431 1437 7 0.7 1431.3 0.5X
3 units w/o interval 1418 1429 11 0.7 1418.2 0.5X
4 units w/ interval 1687 1692 8 0.6 1686.8 0.4X
4 units w/o interval 1679 1688 7 0.6 1679.4 0.5X
5 units w/ interval 1862 1864 3 0.5 1861.9 0.4X
5 units w/o interval 1847 1864 15 0.5 1846.9 0.4X
6 units w/ interval 2067 2081 12 0.5 2066.9 0.4X
6 units w/o interval 2070 2071 2 0.5 2069.6 0.4X
7 units w/ interval 2458 2468 13 0.4 2457.7 0.3X
7 units w/o interval 2450 2453 3 0.4 2450.1 0.3X
8 units w/ interval 2833 2838 8 0.4 2832.6 0.3X
8 units w/o interval 2830 2839 8 0.4 2829.8 0.3X
9 units w/ interval 2873 2880 6 0.3 2873.4 0.3X
9 units w/o interval 2860 2863 3 0.3 2860.1 0.3X
10 units w/ interval 3252 3257 5 0.3 3252.2 0.2X
10 units w/o interval 3212 3220 8 0.3 3211.6 0.2X
11 units w/ interval 3369 3376 6 0.3 3368.5 0.2X
11 units w/o interval 3384 3395 15 0.3 3384.2 0.2X
prepare string w/ interval 448 469 20 2.2 447.6 1.0X
prepare string w/o interval 405 409 4 2.5 404.6 1.1X
1 units w/ interval 321 328 6 3.1 321.4 1.4X
1 units w/o interval 303 307 4 3.3 303.1 1.5X
2 units w/ interval 445 458 12 2.2 444.6 1.0X
2 units w/o interval 416 424 10 2.4 416.2 1.1X
3 units w/ interval 1006 1012 8 1.0 1006.4 0.4X
3 units w/o interval 1240 1249 8 0.8 1239.6 0.4X
4 units w/ interval 1295 1418 106 0.8 1295.4 0.3X
4 units w/o interval 1172 1188 15 0.9 1171.6 0.4X
5 units w/ interval 1326 1335 11 0.8 1325.6 0.3X
5 units w/o interval 1309 1336 44 0.8 1308.7 0.3X
6 units w/ interval 1441 1464 29 0.7 1441.0 0.3X
6 units w/o interval 1350 1369 17 0.7 1350.1 0.3X
7 units w/ interval 1606 1669 99 0.6 1605.6 0.3X
7 units w/o interval 1546 1557 12 0.6 1546.3 0.3X
8 units w/ interval 1771 1875 120 0.6 1770.6 0.3X
8 units w/o interval 1775 1789 13 0.6 1775.2 0.3X
9 units w/ interval 2126 2757 849 0.5 2126.4 0.2X
9 units w/o interval 2053 2070 21 0.5 2053.3 0.2X
10 units w/ interval 2209 2243 30 0.5 2209.1 0.2X
10 units w/o interval 2400 2702 365 0.4 2400.2 0.2X
11 units w/ interval 2616 2699 72 0.4 2616.5 0.2X
11 units w/o interval 3218 3380 195 0.3 3218.4 0.1X

52 changes: 26 additions & 26 deletions sql/core/benchmarks/IntervalBenchmark-results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
OpenJDK 64-Bit Server VM 1.8.0_232-8u232-b09-0ubuntu1~18.04.1-b09 on Linux 4.15.0-1044-aws
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15.3
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
prepare string w/ interval 648 721 94 1.5 648.3 1.0X
prepare string w/o interval 562 596 49 1.8 562.3 1.2X
1 units w/ interval 568 590 21 1.8 568.5 1.1X
1 units w/o interval 522 538 20 1.9 521.7 1.2X
2 units w/ interval 751 754 3 1.3 751.5 0.9X
2 units w/o interval 716 723 6 1.4 716.1 0.9X
3 units w/ interval 1402 1411 11 0.7 1401.6 0.5X
3 units w/o interval 1381 1387 5 0.7 1381.2 0.5X
4 units w/ interval 1591 1595 6 0.6 1591.2 0.4X
4 units w/o interval 1582 1585 3 0.6 1582.3 0.4X
5 units w/ interval 1747 1749 2 0.6 1747.3 0.4X
5 units w/o interval 1738 1746 10 0.6 1737.7 0.4X
6 units w/ interval 1929 1931 3 0.5 1929.1 0.3X
6 units w/o interval 1919 1922 2 0.5 1919.0 0.3X
7 units w/ interval 2345 2354 8 0.4 2345.0 0.3X
7 units w/o interval 2334 2336 2 0.4 2334.1 0.3X
8 units w/ interval 2533 2546 16 0.4 2533.0 0.3X
8 units w/o interval 2519 2521 1 0.4 2519.4 0.3X
9 units w/ interval 2885 2889 5 0.3 2884.5 0.2X
9 units w/o interval 2804 2813 12 0.4 2803.9 0.2X
10 units w/ interval 3041 3060 16 0.3 3041.3 0.2X
10 units w/o interval 3031 3043 15 0.3 3031.2 0.2X
11 units w/ interval 3270 3280 9 0.3 3269.9 0.2X
11 units w/o interval 3273 3280 7 0.3 3272.6 0.2X
prepare string w/ interval 389 410 21 2.6 388.7 1.0X
prepare string w/o interval 340 360 18 2.9 340.5 1.1X
1 units w/ interval 378 389 16 2.6 377.8 1.0X
1 units w/o interval 346 350 5 2.9 346.2 1.1X
2 units w/ interval 444 457 11 2.3 444.2 0.9X
2 units w/o interval 455 464 12 2.2 455.1 0.9X
3 units w/ interval 942 964 20 1.1 941.5 0.4X
3 units w/o interval 927 1020 93 1.1 927.3 0.4X
4 units w/ interval 1114 1127 17 0.9 1113.9 0.3X
4 units w/o interval 1100 1105 4 0.9 1100.3 0.4X
5 units w/ interval 1180 1244 57 0.8 1180.1 0.3X
5 units w/o interval 1135 1141 6 0.9 1135.2 0.3X
6 units w/ interval 1284 1316 48 0.8 1284.0 0.3X
6 units w/o interval 1276 1357 122 0.8 1276.1 0.3X
7 units w/ interval 1609 1636 32 0.6 1609.1 0.2X
7 units w/o interval 1551 1578 36 0.6 1550.9 0.3X
8 units w/ interval 1787 1874 129 0.6 1787.1 0.2X
8 units w/o interval 1751 1767 15 0.6 1750.6 0.2X
9 units w/ interval 1960 2065 141 0.5 1959.7 0.2X
9 units w/o interval 1885 1908 39 0.5 1885.1 0.2X
10 units w/ interval 2178 2185 11 0.5 2177.9 0.2X
10 units w/o interval 2150 2255 164 0.5 2150.1 0.2X
11 units w/ interval 2457 2542 139 0.4 2456.7 0.2X
11 units w/o interval 2557 2770 188 0.4 2556.7 0.2X

4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DateTimeBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@ object DateTimeBenchmark extends SqlBasedBenchmark {
}
runBenchmark("Parsing") {
val n = 1000000
val timestampStrExpr = "concat('2019-01-27 11:02:01.', cast(mod(id, 1000) as string))"
val timestampStrExpr = "concat('2019-01-27 11:02:01.', rpad(mod(id, 1000), 3, '0'))"
val pattern = "'yyyy-MM-dd HH:mm:ss.SSS'"
Copy link
Contributor

@cloud-fan cloud-fan Mar 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thought: maybe we should change the pattern string to yyyy-M-d H: m:s.S, to match the behavior of 2.4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will fail with 2019-01-27 11:02:01.12(123)

run(n, "to timestamp str", timestampStrExpr)
run(n, "to_timestamp", s"to_timestamp($timestampStrExpr, $pattern)")
run(n, "to_unix_timestamp", s"to_unix_timestamp($timestampStrExpr, $pattern)")
val dateStrExpr = "concat('2019-01-', cast(mod(id, 25) as string))"
val dateStrExpr = "concat('2019-01-', lpad(mod(id, 25), 2, '0'))"
run(n, "to date str", dateStrExpr)
run(n, "to_date", s"to_date($dateStrExpr, 'yyyy-MM-dd')")
}
Expand Down
4 changes: 3 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/IntervalBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ object IntervalBenchmark extends SqlBasedBenchmark {
spark
.range(0, cardinality, 1, 1)
.select(exprs: _*)
.noop()
.queryExecution
.toRdd
.foreach(_ => ())
}
}

Expand Down