-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-29924][DOCS] Document Apache Arrow JDK11 requirement #27356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @HyukjinKwon , @BryanCutler , @srowen . |
Test build #117369 has finished for PR 27356 at commit
|
Thank you, @srowen . Merged to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dongjoon-hyun !
Thank you, @BryanCutler ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @HyukjinKwon . It's a holiday in South Korea, isn't it? 😉 |
Will the io.netty.tryReflectionSetAccessible=true be set automatically at any point in the future, or will users always need to set this manually? Is there a downside to always setting this to true? Thanks for your help here :) |
@chogg . Unfortunately, Could you ask that to the Netty or Apache Arrow community instead? |
Hello. For information we observed that this setting seems to not be required anymore with new versions of the libraries. See jupyter/docker-stacks#1256 for detail. Best. |
Thanks for heads up @romainx. Would you be interested in fixing it? See also http://spark.apache.org/contributing.html |
@HyukjinKwon sure I will have a look and I will try to draft a PR, it could take some time since it's my first contribution here. Thanks for the proposal. |
Sure, thanks. |
What changes were proposed in this pull request?
This adds a note for additional setting for Apache Arrow library for Java 11.
Why are the changes needed?
Since Apache Arrow 0.14.0, an additional setting is required for Java 9+.
It's explicitly documented at Apache Arrow 0.15.0.
However, there is no plan to handle that inside Apache Arrow side.
In short, we need to document this for the users who is using Arrow-related feature on JDK11.
For dev environment, we handle this via SPARK-29923 .
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Generated document and see the pages.