Skip to content

[SPARK-30617][SQL] Stop check values of spark.sql.catalogImplementation to improve expansibility #27338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

WeiWenda
Copy link

What changes were proposed in this pull request?

When user config spark.sql.catalogImplementation with value not in in-memory/hive, check if below properties is configured. If configured then instantiate SessionState with provided Class, or else throw Exception as usual.

spark.sql.catalogImplementation.[value of spark.sql.catalogImplementation].builder
spark.sql.catalogImplementation.[value of spark.sql.catalogImplementation].externalCatalog

For example:

spark.sql.catalogImplementation = qihoo
spark.sql.catalogImplementation.qihoo.builder = org.apache.spark.sql.qihoo.QihooSessionStateBuilder
spark.sql.catalogImplementation.qihoo.externalCatalog = org.apache.spark.sql.qihoo.QihooExternalCatalog

Why are the changes needed?

We have implemented a complex ExternalCatalog which is used for retrieving multi isomerism database's metadata(sush as elasticsearch、postgresql), so that we can make a mixture query between hive and our online data. But as spark require that value of spark.sql.catalogImplementation must be one of in-memory/hive, we have to modify SparkSession and rebuild spark to make our project work.
Finally, we hope spark removing above restriction, so that it's will be much easier to let us keep pace with new spark version. Thanks!

Does this PR introduce any user-facing change?

no

How was this patch tested?

no

@WeiWenda WeiWenda changed the title stop check values of spark.sql.catalogImplementation to improve expansibility [SPARK-30617] stop check values of spark.sql.catalogImplementation to improve expansibility Jan 23, 2020
@WeiWenda WeiWenda changed the title [SPARK-30617] stop check values of spark.sql.catalogImplementation to improve expansibility [SPARK-30617][SQL] Stop check values of spark.sql.catalogImplementation to improve expansibility Jan 23, 2020
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

…proach to let user define themselves metadata catalog
@dongjoon-hyun
Copy link
Member

Hi, @WeiWenda . I'll close this PR. Please open to the master branch first.
For all patches, we need to consider master first. Otherwise, we will miss something in 3.0.0.

@WeiWenda
Copy link
Author

Thanks for your remind. I have opened a new pr at #27349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants