Skip to content

[SPARK-30282][DOCS][FOLLOWUP] Update SQL migration guide for SHOW TBLPROPERTIES #27276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

imback82
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds a migration guide for SHOW TBLPROPERTIES for Apache Spark 3.0.0.

Why are the changes needed?

The behavior of SHOW TBLPROPERTIES changed when the table does not exist. The migration guide reflects this user facing change.

Does this PR introduce any user-facing change?

Yes. This is a documentation change.

How was this patch tested?

No tests were added because this is a doc change.

@imback82
Copy link
Contributor Author

cc: @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Jan 19, 2020

Test build #116985 has finished for PR 27276 at commit d6fa318.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class JavaRegressor(JavaPredictor, _JavaPredictorParams):
  • class JavaRegressionModel(JavaPredictionModel, _JavaPredictorParams):
  • class LinearRegression(JavaRegressor, _LinearRegressionParams, JavaMLWritable, JavaMLReadable):
  • class LinearRegressionModel(JavaRegressionModel, _LinearRegressionParams, GeneralJavaMLWritable,
  • class DecisionTreeRegressor(JavaRegressor, _DecisionTreeRegressorParams, JavaMLWritable,
  • class DecisionTreeRegressionModel(
  • class RandomForestRegressor(JavaRegressor, _RandomForestRegressorParams, JavaMLWritable,
  • class RandomForestRegressionModel(
  • class GBTRegressor(JavaRegressor, _GBTRegressorParams, JavaMLWritable, JavaMLReadable):
  • class GBTRegressionModel(
  • class AFTSurvivalRegression(JavaRegressor, _AFTSurvivalRegressionParams,
  • class AFTSurvivalRegressionModel(JavaRegressionModel, _AFTSurvivalRegressionParams,
  • class GeneralizedLinearRegression(JavaRegressor, _GeneralizedLinearRegressionParams,
  • class GeneralizedLinearRegressionModel(JavaRegressionModel, _GeneralizedLinearRegressionParams,
  • class FMRegressor(JavaRegressor, _FactorizationMachinesParams, JavaMLWritable, JavaMLReadable):
  • class FMRegressionModel(JavaRegressionModel, _FactorizationMachinesParams, JavaMLWritable,

@SparkQA
Copy link

SparkQA commented Jan 19, 2020

Test build #116983 has finished for PR 27276 at commit 7eecb41.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@@ -340,6 +340,8 @@ license: |

- Since Spark 3.0, `SHOW TBLPROPERTIES` on a temporary view will cause `AnalysisException`. In Spark version 2.4 and earlier, it returned an empty result.

- Since Spark 3.0, `SHOW TBLPROPERTIES` will cause `AnalysisException` if the table does not exist. In Spark version 2.4 and earlier, this scenario caused `NoSuchTableException`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge the above two into one?

- Since Spark 3.0, `SHOW TBLPROPERTIES` will cause `AnalysisException` if the table does not exist. In Spark version 2.4 and earlier, this scenario caused `NoSuchTableException`. Also, `SHOW TBLPROPERTIES` on a temporary view will cause `AnalysisException`. In Spark version 2.4 and earlier, it returned an empty result.

@SparkQA
Copy link

SparkQA commented Jan 19, 2020

Test build #117026 has finished for PR 27276 at commit d6fa318.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class JavaRegressor(JavaPredictor, _JavaPredictorParams):
  • class JavaRegressionModel(JavaPredictionModel, _JavaPredictorParams):
  • class LinearRegression(JavaRegressor, _LinearRegressionParams, JavaMLWritable, JavaMLReadable):
  • class LinearRegressionModel(JavaRegressionModel, _LinearRegressionParams, GeneralJavaMLWritable,
  • class DecisionTreeRegressor(JavaRegressor, _DecisionTreeRegressorParams, JavaMLWritable,
  • class DecisionTreeRegressionModel(
  • class RandomForestRegressor(JavaRegressor, _RandomForestRegressorParams, JavaMLWritable,
  • class RandomForestRegressionModel(
  • class GBTRegressor(JavaRegressor, _GBTRegressorParams, JavaMLWritable, JavaMLReadable):
  • class GBTRegressionModel(
  • class AFTSurvivalRegression(JavaRegressor, _AFTSurvivalRegressionParams,
  • class AFTSurvivalRegressionModel(JavaRegressionModel, _AFTSurvivalRegressionParams,
  • class GeneralizedLinearRegression(JavaRegressor, _GeneralizedLinearRegressionParams,
  • class GeneralizedLinearRegressionModel(JavaRegressionModel, _GeneralizedLinearRegressionParams,
  • class FMRegressor(JavaRegressor, _FactorizationMachinesParams, JavaMLWritable, JavaMLReadable):
  • class FMRegressionModel(JavaRegressionModel, _FactorizationMachinesParams, JavaMLWritable,

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending Jenkins.)

@SparkQA
Copy link

SparkQA commented Jan 19, 2020

Test build #117027 has finished for PR 27276 at commit 68131b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you, @imback82 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants