-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-30282][DOCS][FOLLOWUP] Update SQL migration guide for SHOW TBLPROPERTIES #27276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc: @dongjoon-hyun |
Test build #116985 has finished for PR 27276 at commit
|
Test build #116983 has finished for PR 27276 at commit
|
Retest this please. |
docs/sql-migration-guide.md
Outdated
@@ -340,6 +340,8 @@ license: | | |||
|
|||
- Since Spark 3.0, `SHOW TBLPROPERTIES` on a temporary view will cause `AnalysisException`. In Spark version 2.4 and earlier, it returned an empty result. | |||
|
|||
- Since Spark 3.0, `SHOW TBLPROPERTIES` will cause `AnalysisException` if the table does not exist. In Spark version 2.4 and earlier, this scenario caused `NoSuchTableException`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge the above two into one?
- Since Spark 3.0, `SHOW TBLPROPERTIES` will cause `AnalysisException` if the table does not exist. In Spark version 2.4 and earlier, this scenario caused `NoSuchTableException`. Also, `SHOW TBLPROPERTIES` on a temporary view will cause `AnalysisException`. In Spark version 2.4 and earlier, it returned an empty result.
Test build #117026 has finished for PR 27276 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. (Pending Jenkins.)
Test build #117027 has finished for PR 27276 at commit
|
Merged to master. Thank you, @imback82 . |
What changes were proposed in this pull request?
This PR adds a migration guide for
SHOW TBLPROPERTIES
for Apache Spark 3.0.0.Why are the changes needed?
The behavior of
SHOW TBLPROPERTIES
changed when the table does not exist. The migration guide reflects this user facing change.Does this PR introduce any user-facing change?
Yes. This is a documentation change.
How was this patch tested?
No tests were added because this is a doc change.