Skip to content

[SPARK-30409][TEST][FOLLOWUP][HOTFIX] Remove dangling JSONBenchmark-jdk11-results.txt #27180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 12, 2020

What changes were proposed in this pull request?

This PR removes a dangling test result, JSONBenchmark-jdk11-results.txt.
This causes a case-sensitive issue on Mac.

$ git clone https://gitbox.apache.org/repos/asf/spark.git spark-gitbox
Cloning into 'spark-gitbox'...
remote: Counting objects: 671717, done.
remote: Compressing objects: 100% (258021/258021), done.
remote: Total 671717 (delta 329181), reused 560390 (delta 228097)
Receiving objects: 100% (671717/671717), 149.69 MiB | 950.00 KiB/s, done.
Resolving deltas: 100% (329181/329181), done.
Updating files: 100% (16090/16090), done.
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'sql/core/benchmarks/JSONBenchmark-jdk11-results.txt'
  'sql/core/benchmarks/JsonBenchmark-jdk11-results.txt'

Why are the changes needed?

Previously, since the file name didn't match with object JSONBenchmark, it made a confusion when we ran the benchmark. So, 4e0e4e5 renamed JSONBenchmark to JsonBenchmark. However, at the same time frame, #26003 regenerated this file.

Recently, #27078 regenerates the results with the correct file name, JsonBenchmark-jdk11-results.txt. So, we can remove the old one.

Does this PR introduce any user-facing change?

No. This is a test result.

How was this patch tested?

Manually check the following correctly generated files in the master. And, check this PR removes the dangling one.

@dongjoon-hyun
Copy link
Member Author

cc @srowen and @HyukjinKwon

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][TEST] Remove dangling JSONBenchmark-jdk11-results.txt [SPARK-30409][TEST][HOTFIX] Remove dangling JSONBenchmark-jdk11-results.txt Jan 12, 2020
@dongjoon-hyun
Copy link
Member Author

This is caused by the original PRs (mine), but the error exposed with SPARK-30409. I just used the latest issue ID, @MaxGekk .

@srowen
Copy link
Member

srowen commented Jan 12, 2020

OK if it's not used.

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @srowen . Yes. This is not used.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30409][TEST][HOTFIX] Remove dangling JSONBenchmark-jdk11-results.txt [SPARK-30409][TEST][FOLLOWUP][HOTFIX] Remove dangling JSONBenchmark-jdk11-results.txt Jan 12, 2020
@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-REMOVE branch January 12, 2020 23:46
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jan 13, 2020

Test build #116573 has finished for PR 27180 at commit 40470c9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants