Skip to content

Conversation

@HeartSaVioR
Copy link
Contributor

What changes were proposed in this pull request?

This patch is the part 3 of SPARK-29779 and addresses remaining functionality: integrate compaction into FsHistoryProvider. This patch also addresses documentation about new configuration. Please refer the description of PR #27085 to see overall rationalization of this patch.

Why are the changes needed?

One of major goal of SPARK-28594 is to prevent the event logs to become too huge, and SPARK-29779 achieves the goal. We've got another approach in prior, but the old approach required models in both KVStore and live entities to guarantee compatibility, while they're not designed to do so.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added UT. Manual test will follow once earlier parts are merged and this patch is rebased.

@HeartSaVioR
Copy link
Contributor Author

I'll split out caching the state of event filter builder to follow-up JIRA issue, as it's not mandatory to finalize SPARK-29779.

@HeartSaVioR HeartSaVioR changed the title [SPARK-29779][CORE] Compact old event log files and cleanup - part 3 [WIP][SPARK-29779][CORE] Compact old event log files and cleanup - part 3 Jan 3, 2020
@HeartSaVioR
Copy link
Contributor Author

#27086 is the part 2 of SPARK-29779 - please review it first. Once we merged the part 2, I'll rebase this patch and remove WIP tag.

@SparkQA
Copy link

SparkQA commented Jan 3, 2020

Test build #116076 has finished for PR 27087 at commit 4bade08.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor Author

Superseded by #27208

@HeartSaVioR HeartSaVioR deleted the SPARK-29779-part3 branch January 15, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants