-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-30258][TESTS] Eliminate warnings of deprecated Spark APIs in tests #26885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #115317 has finished for PR 26885 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still need to test the deprecated methods? while they're still around they need to work.
I agree that all deprecated methods need to work. I moved those tests to special test suites with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so there's no net change in tests? this seems like a good approach if so.
Right |
Merged to master |
What changes were proposed in this pull request?
In the PR, I propose to move all tests that use deprecated Spark APIs to separate test classes, and add the annotation:
The annotation suppress warnings from already deprecated methods and classes.
Why are the changes needed?
The warnings about deprecated Spark APIs in tests does not indicate any issues because the tests use such APIs intentionally. Eliminating the warnings allows to highlight other warnings that could show real problems.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing test suites and by