[SPARK-30221] Enhanced implementation of PrometheusPushGateWaySink #26852
Conversation
|
Can one of the admins verify this patch? |
|
Thank you for making your first contribution, @XuQianJin-Stars . |
|
Could you explain the difference from #19775? |
| /** | ||
| * PrometheusPushGateWay that exports Metric Metrics via Prometheus PushGateway. | ||
| */ | ||
| private[spark] class PrometheusPushGateWay( |
There was a problem hiding this comment.
Why not having this as a third party library?
There was a problem hiding this comment.
Could you explain the difference from #19775?
hi @dongjoon-hyun Thank you very much, There is no difference in functionality. I don't see it in the spark source code, so I implemented it myself. #19775 is better written. I will close this PR.
| <dependency> | ||
| <groupId>io.prometheus</groupId> | ||
| <artifactId>simpleclient_pushgateway</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Since this is a new dependency, could you confirm if this is compatible and tested with JDK11 please?
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
Enhanced implementation of PrometheusPushGateWaySink.
Why are the changes needed?
PrometheusPushGateWaySink supports metrics push to PrometheusPushGateWay.
Does this PR introduce any user-facing change?
Added PrometheusPushGateWay class.
How was this patch tested?
None