Skip to content

Revert "[SPARK-29644][SQL] Corrected ShortType and ByteType mapping to SmallInt and TinyInt in JDBCUtils #26583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shivsood
Copy link
Contributor

This reverts commit f7e53865 i.e PR #26301 from master

…o SmallInt and TinyInt in JDBCUtils"

This reverts commit 32d44b1.
@shivsood
Copy link
Contributor Author

@dongjoon-hyun as FYI on revert for #26301 in master

@dongjoon-hyun
Copy link
Member

Ur, do you want to revert fully? What I meant was the ByteType <-> TinyInt part only.
For the full revert, I can do that without making a PR.

@dongjoon-hyun
Copy link
Member

cc @gatorsmile , @srowen

@shivsood
Copy link
Contributor Author

@dongjoon-hyun 'll prefer a full revert to keep this clean and inline with what was done in 2.4. I will come back with PR for ShortType and ByteType separately as i get better grasp of the issue and fix.

@HyukjinKwon
Copy link
Member

ok to test

@HyukjinKwon
Copy link
Member

Either way seems fine to me. Let me merge this since the PR is open already.

@SparkQA
Copy link

SparkQA commented Nov 19, 2019

Test build #114036 has finished for PR 26583 at commit eabfaf9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is revert. Merged to master.

@srowen
Copy link
Member

srowen commented Nov 19, 2019

Just for my info, all of the related changes in 2.4 are fully reverted now, so we can focus on master?

@dongjoon-hyun
Copy link
Member

Yes. We checked the other TinyInt <-> ByteType mapping commits, but it's a legitimate dialect for H2 database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants