[SPARK-29781][BUILD][2.4] Override SBT Jackson dependency like Maven #26417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #113345 has finished for PR 26417 at commit
|
|
Retest this please |
|
Test build #113346 has finished for PR 26417 at commit
|
|
Retest this please. |
|
Test build #113352 has finished for PR 26417 at commit
|
|
Although it's irrelevant,
|
|
Retest this please |
|
Test build #113391 has finished for PR 26417 at commit
|
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 7, 2019
…gnore preview release ### What changes were proposed in this pull request? This aims to exclude the `preview` release to recover `HiveExternalCatalogVersionsSuite`. Currently, new preview release breaks `branch-2.4` PRBuilder since yesterday. New release (especially `preview`) should not affect `branch-2.4`. - #26417 (Failed 4 times) ### Why are the changes needed? **BEFORE** ```scala scala> scala.io.Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString.split("\n").filter(_.contains("""<li><a href="spark-""")).map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) java.util.NoSuchElementException: None.get ``` **AFTER** ```scala scala> scala.io.Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString.split("\n").filter(_.contains("""<li><a href="spark-""")).filterNot(_.contains("preview")).map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) res5: Array[String] = Array(2.3.4, 2.4.4) ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This should pass the PRBuilder. Closes #26428 from dongjoon-hyun/SPARK-HiveExternalCatalogVersionsSuite. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 7, 2019
…gnore preview release ### What changes were proposed in this pull request? This aims to exclude the `preview` release to recover `HiveExternalCatalogVersionsSuite`. Currently, new preview release breaks `branch-2.4` PRBuilder since yesterday. New release (especially `preview`) should not affect `branch-2.4`. - #26417 (Failed 4 times) ### Why are the changes needed? **BEFORE** ```scala scala> scala.io.Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString.split("\n").filter(_.contains("""<li><a href="spark-""")).map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) java.util.NoSuchElementException: None.get ``` **AFTER** ```scala scala> scala.io.Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString.split("\n").filter(_.contains("""<li><a href="spark-""")).filterNot(_.contains("preview")).map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) res5: Array[String] = Array(2.3.4, 2.4.4) ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This should pass the PRBuilder. Closes #26428 from dongjoon-hyun/SPARK-HiveExternalCatalogVersionsSuite. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit da848b1) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Retest this please |
|
Test build #113398 has finished for PR 26417 at commit
|
|
LGTM. Thanks. |
|
Thank you for review and approval, @dbtsai . |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 7, 2019
### What changes were proposed in this pull request? This PR aims to override SBT `jackson-databind` dependency like Maven in `branch-2.4`. ### Why are the changes needed? Without this, SBT and Maven works differently in `branch-2.4`. We had better fix this in `branch-2.4` because it's our LTS branch. ``` $ build/sbt -Phadoop-3.1 "core/testOnly *.ShuffleDependencySuite" [info] ShuffleDependencySuite: [info] org.apache.spark.shuffle.ShuffleDependencySuite *** ABORTED *** ... [info] Cause: com.fasterxml.jackson.databind.JsonMappingException: Incompatible Jackson version: 2.7.8 ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually do `build/sbt -Phadoop-3.1 "core/testOnly *.ShuffleDependencySuite"`. Closes #26417 from dongjoon-hyun/SPARK-29781. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to override SBT
jackson-databinddependency like Maven inbranch-2.4.Why are the changes needed?
Without this, SBT and Maven works differently in
branch-2.4. We had better fix this inbranch-2.4because it's our LTS branch.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually do
build/sbt -Phadoop-3.1 "core/testOnly *.ShuffleDependencySuite".