Skip to content

Conversation

@PavithraRamachandran
Copy link
Contributor

On clicking job description in jobs page, the description was not shown fully.
Add the function for the click event on description.

when there is a long description of a job, it cannot be seen fully in the UI.
The feature was added in #24145
But it is missed after #25374

Before change:
Screenshot from 2019-10-23 11-23-00
After change: on Double click over decription
Screenshot from 2019-10-23 11-20-02

No

Manually test

On clicking job description in jobs page, the description was not shown fully.
Add the function for the click event on description.

when there is a long description of a job, it cannot be seen fully in the UI.
The feature was added in apache#24145
But it is missed after apache#25374

Before change:
![Screenshot from 2019-10-23 11-23-00](https://user-images.githubusercontent.com/51401130/67361914-827b0080-f587-11e9-9181-d49a6a836046.png)
After change: on Double click over decription
![Screenshot from 2019-10-23 11-20-02](https://user-images.githubusercontent.com/51401130/67361936-932b7680-f587-11e9-9e59-d290abed4b70.png)

No

Manually test

Closes apache#26222 from PavithraRamachandran/jobs_description_tooltip.

Authored-by: Pavithra Ramachandran <pavi.rams@gmail.com>
Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com>
@PavithraRamachandran
Copy link
Contributor Author

@gengliangwang i have raised for 2.4 branch. Could you verify?

collapseTablePageLoad('collapse-aggregated-rdds','aggregated-rdds');
collapseTablePageLoad('collapse-aggregated-activeBatches','aggregated-activeBatches');
collapseTablePageLoad('collapse-aggregated-completedBatches','aggregated-completedBatches');
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add a blank line here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the blank space as per the review comment. Could you verify

@gengliangwang
Copy link
Member

ok to test.

@SparkQA
Copy link

SparkQA commented Oct 31, 2019

Test build #113041 has finished for PR 26336 at commit 14de92f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2019

Test build #113119 has finished for PR 26336 at commit edbfd60.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member

Hi @PavithraRamachandran ,

After building and running test manually with the changes, I found it doesn't work well: on double click the class description-input is removed.
In the original PR #25484, the file additional-metrics.js is not removed.
I am closing this PR now.
Sorry I didn't look close into #25484 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants