[SPARK-21287][SQL] Remove requirement of fetch_size>=0 from JDBCOptions #26244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
OK to test |
srowen
approved these changes
Oct 24, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
I think this is fine, maybe just simpler. OK pending tests.
dongjoon-hyun
approved these changes
Oct 24, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Yes. I agree. +1, LGTM.
Member
|
ok to test |
|
Test build #112612 has finished for PR 26244 at commit
|
Member
|
Merged to master/2.4. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 24, 2019
### What changes were proposed in this pull request? Remove the requirement of fetch_size>=0 from JDBCOptions to allow negative fetch size. ### Why are the changes needed? Namely, to allow data fetch in stream manner (row-by-row fetch) against MySQL database. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit test (JDBCSuite) This closes #26230 . Closes #26244 from fuwhu/SPARK-21287-FIX. Authored-by: fuwhu <bestwwg@163.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 92b2529) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
oh, I'm late... this one looks nicer and thx! |
HyukjinKwon
reviewed
Oct 25, 2019
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM too. Thanks for quick PR, review and merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the requirement of fetch_size>=0 from JDBCOptions to allow negative fetch size.
Why are the changes needed?
Namely, to allow data fetch in stream manner (row-by-row fetch) against MySQL database.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test (JDBCSuite)
This closes #26230 .