[SPARK-28892][SQL][followup] add resolved logical plan for UPDATE TABLE #26025
Conversation
|
cc @xianyinxin |
cloud-fan
changed the title
|
Test build #111781 has finished for PR 26025 at commit
|
|
The UT failure looks relevant. |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
So are we extracting some of DDL relative plans in this commands.scala? But there're still other commands in basicLogicalOperators.scala. What's the relation of the two?
There was a problem hiding this comment.
I'd like to put all the DDL/DML commands in this file, starting with DELETE/UPDATE
There was a problem hiding this comment.
Actually, let me do it together in an individual PR.
| LocalRelation(a)) | ||
| assertAnalysisError(plan, "Predicate sub-queries can only be used" + | ||
| " in Filter/DeleteFromTable" :: Nil) | ||
| " in Filter" :: Nil) |
There was a problem hiding this comment.
Why there isn't the new SupportsSubquery?
There was a problem hiding this comment.
SupportsSubquery is an internal class and end-users don't know what it is. So I just put "a few commands", see https://github.com/apache/spark/pull/26025/files#diff-1d14ac233eac6f233c027dba0bdf871dR608
|
General LGTM. |
|
Test build #111803 has finished for PR 26025 at commit
|
|
Test build #111834 has finished for PR 26025 at commit
|
|
retest this please |
|
Test build #111840 has finished for PR 26025 at commit
|
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to master.
|
cc @brkyvz |
### What changes were proposed in this pull request? Add back the resolved logical plan for UPDATE TABLE. It was in apache#25626 before but was removed later. ### Why are the changes needed? In apache#25626 , we decided to not add the update API in DS v2, but we still want to implement UPDATE for builtin source like JDBC. We should at least add the resolved logical plan. ### Does this PR introduce any user-facing change? no, UPDATE is still not supported yet. ### How was this patch tested? new tests. Closes apache#26025 from cloud-fan/update. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Xiao Li <gatorsmile@gmail.com>
5 participants
What changes were proposed in this pull request?
Add back the resolved logical plan for UPDATE TABLE. It was in #25626 before but was removed later.
Why are the changes needed?
In #25626 , we decided to not add the update API in DS v2, but we still want to implement UPDATE for builtin source like JDBC. We should at least add the resolved logical plan.
Does this PR introduce any user-facing change?
no, UPDATE is still not supported yet.
How was this patch tested?
new tests.