Skip to content

Conversation

@HeartSaVioR
Copy link
Contributor

What changes were proposed in this pull request?

This patch fixes the order of elements while logging token. Header columns are printed as

"TOKENID", "HMAC", "OWNER", "RENEWERS", "ISSUEDATE", "EXPIRYDATE", "MAXDATE"

whereas the code prints out actual information as

"HMAC"(redacted), "TOKENID", "OWNER", "RENEWERS", "ISSUEDATE", "EXPIRYDATE", "MAXDATE"

This patch fixes this.

Why are the changes needed?

Not critical but it doesn't line up with header columns.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A, as it's only logged as debug and it's obvious what/where is the problem and how it can be fixed.

@HeartSaVioR
Copy link
Contributor Author

cc. @vanzin @gaborgsomogyi @dongjoon-hyun as author/reviewers of SPARK-27748 (#24627)

@SparkQA
Copy link

SparkQA commented Sep 26, 2019

Test build #111395 has finished for PR 25935 at commit b309f70.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor Author

Starting test(python3.6): pyspark.sql.tests.test_session
Attempting to post to Github...
Post successful.
Process leaked file descriptors. See http://wiki.jenkins-ci.org/display/JENKINS/Spawning+processes+from+build for more information
Build step 'Execute shell' marked build as failure

Looks like pyspark failure but just somewhat crashed which log is only available in CI machine. I'll just retrigger the build.

@HeartSaVioR
Copy link
Contributor Author

retest this, please

@SparkQA
Copy link

SparkQA commented Sep 26, 2019

Test build #111402 has finished for PR 25935 at commit b309f70.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@gaborgsomogyi gaborgsomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch!

@vanzin
Copy link
Contributor

vanzin commented Sep 26, 2019

Merging to master.

@vanzin vanzin closed this in d3679a9 Sep 26, 2019
@HeartSaVioR
Copy link
Contributor Author

Thanks all for reviewing and merging!

@HeartSaVioR HeartSaVioR deleted the SPARK-27748-FOLLOWUP branch September 26, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants