[SPARK-29230][CORE][TEST] Fix NPE in ProcfsMetricsGetterSuite #25918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ProcfsMetricsGetterSuite
|
Test build #4883 has started for PR 25918 at commit |
srowen
reviewed
Sep 24, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks OK to me pending tests. The change makes sense even if it wasn't solving a problem; no need for that to be an instance variable.
Contributor
Author
|
Thanks for your reviewing！ @srowen |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Sep 24, 2019
Member
Member
|
And, welcome to the Apache Spark community, @sev7e0 . You are added to the Apache Spark contributor group and https://issues.apache.org/jira/browse/SPARK-29230 is assigned to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When I use
ProcfsMetricsGetterSuite fortesting, always throw outjava.lang.NullPointerException. I think there is a problem with locatingnew ProcfsMetricsGetter, which will lead toSparkEnvnot being initialized in time. This leads tojava.lang.NullPointerExceptionwhen the method is executed.Why are the changes needed?
For test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Local testing