[SPARK-28471][SQL][DOC][FOLLOWUP] Fix year patterns in the comments of date-time expressions #25796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
commented
Sep 15, 2019
| * See [https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html]. | ||
| * Note that hive Language Manual says it returns 0 if fail, but in fact it returns null. | ||
| * If the second parameter is missing, use "yyyy-MM-dd HH:mm:ss". | ||
| * If the second parameter is missing, use "uuuu-MM-dd HH:mm:ss". |
Member
Author
There was a problem hiding this comment.
MaxGekk
commented
Sep 15, 2019
|
|
||
| /** | ||
| * The formatter parses/formats timestamps according to the pattern `yyyy-MM-dd HH:mm:ss.[..fff..]` | ||
| * The formatter parses/formats timestamps according to the pattern `uuuu-MM-dd HH:mm:ss.[..fff..]` |
Member
Author
There was a problem hiding this comment.
ISO_LOCAL_DATE (
uuuu
MaxGekk
commented
Sep 15, 2019
| * @param dateExpr A date, timestamp or string. If a string, the data must be in a format that | ||
| * can be cast to a timestamp, such as `yyyy-MM-dd` or `yyyy-MM-dd HH:mm:ss.SSSS` | ||
| * @param format A pattern `dd.MM.yyyy` would return a string like `18.03.1993` | ||
| * can be cast to a timestamp, such as `uuuu-MM-dd` or `uuuu-MM-dd HH:mm:ss.SSSS` |
Member
Author
There was a problem hiding this comment.
It uses TimestampFormatter which can output negative years using the uuuu pattern.
|
Test build #110621 has finished for PR 25796 at commit
|
dongjoon-hyun
approved these changes
Sep 15, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to fix comments of date-time expressions, and replace the
yyyypattern byuuuuwhen the implementation supposes the former one.Why are the changes needed?
To make comments consistent to implementations.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running Scala Style checker.