-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-28921][BUILD][K8S] Upgrade kubernetes client to 4.4.2 #25640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@andygrove any possible incompatibilities or gotchas that might arise from the update? I suspect it's fine. |
Test build #4848 has finished for PR 25640 at commit
|
Oh, you'll need to run |
I suspect it is fine too. kubernetes client 4.4.2 has jackson 2.9.9 instead of jackson 2.9.8 with the 4.1.2 release, but hopefully that's a non issue |
Should be fine. We're on 2.9.9.x in Spark. |
Retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. (Pending Jenkins. I also triggered JDK11 test to make it sure).
Thank you so much for the fix, @andygrove .
Also, if possible, please specify the version number of EKS which you are mentioning, @andygrove . |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #4855 has finished for PR 25640 at commit
|
Test build #109989 has finished for PR 25640 at commit
|
cc @skonto , too. |
I updated the JIRA title. So far, this has been reported against versions 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable to me
Hi, @andygrove . For Spark testing environments, it looks good. I'd like to verify this PR in EKS since you reported this for that. When I check the EKS today, it seems to show BTW, to understand your procedure, I visited your interesting blog article. I have one question about your article; Why do you think this is the existing Apache Spark's 2.3/2.4 regression? Those releases work with the old K8S releases and still do. Did I miss something? In Apache Arrow project, do you think some 3rd party library's future release is considered as the existing Apache Arrow library's regression? For me, it's just unsupported version issue, isn't it? According to your last sentence, I'm waiting for your update on that blog.
|
@dongjoon-hyun The regression is with EKS, not with Spark ... I guess I could have picked a better title for the blog post. I'll update that. Once connected to the EKS cluster, I run The initial testing I'm doing is just running our automated integration test suite for the service that my team works on, and this causes Spark jobs to run in EKS. Basically we're just running spark jobs using It's Labor day in the US today so I won't be back at work until tomorrow, but we have tests passing now because I followed the instructions in the blog post and built a release based on my PR against 2.3 and it got past the issue. |
Got it. Thank you for the detailed explanation, @andygrove . I'll verify on EKS and merge your PR today~ |
This PR is tested with
Thank you, @andygrove , @srowen , @felixcheung . Merged to |
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
…ion-tests ### What changes were proposed in this pull request? Per #25640 (comment) also bump K8S client version in integration-tests module. ### Why are the changes needed? Harmonize the version as intended. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests. Closes #25664 from srowen/SPARK-28921.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
…ion-tests ### What changes were proposed in this pull request? Per #25640 (comment) also bump K8S client version in integration-tests module. ### Why are the changes needed? Harmonize the version as intended. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests. Closes #25664 from srowen/SPARK-28921.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com> (cherry picked from commit ded23f8) Signed-off-by: Sean Owen <sean.owen@databricks.com>
…ion-tests ### What changes were proposed in this pull request? Per apache#25640 (comment) also bump K8S client version in integration-tests module. ### Why are the changes needed? Harmonize the version as intended. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests. Closes apache#25664 from srowen/SPARK-28921.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com> (cherry picked from commit ded23f8) Signed-off-by: Sean Owen <sean.owen@databricks.com>
…ion-tests ### What changes were proposed in this pull request? Per apache#25640 (comment) also bump K8S client version in integration-tests module. ### Why are the changes needed? Harmonize the version as intended. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests. Closes apache#25664 from srowen/SPARK-28921.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com> (cherry picked from commit ded23f8) Signed-off-by: Sean Owen <sean.owen@databricks.com> (cherry picked from commit 0566fd0)
…ion-tests ### What changes were proposed in this pull request? Per apache#25640 (comment) also bump K8S client version in integration-tests module. ### Why are the changes needed? Harmonize the version as intended. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests. Closes apache#25664 from srowen/SPARK-28921.2. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com> (cherry picked from commit ded23f8) Signed-off-by: Sean Owen <sean.owen@databricks.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Upgrade kubernetes client from 4.1.2 to 4.4.2 To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10. No Pass the Jenkins and manually test on EKS. Closes apache#25640 from andygrove/SPARK-28921. Authored-by: Andy Grove <andygrove73@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> Co-authored-by: Andy Grove <andygrove73@gmail.com>
What changes were proposed in this pull request?
Upgrade kubernetes client from 4.1.2 to 4.4.2
Why are the changes needed?
To fix compatibility issue with EKS since Amazon rolled out some security patches over the past week; 1.15.3, 1.14.6, 1.13.10, 1.12.10, and 1.11.10.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins and manually test on EKS.