Skip to content

[SPARK-28795][DOC][SQL] Document CREATE VIEW statement in SQL Reference #25543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[SPARK-28795][DOC][SQL] Document CREATE VIEW statement in SQL Reference #25543

wants to merge 7 commits into from

Conversation

@amanomer
Copy link
Contributor

@amanomer amanomer commented Aug 21, 2019

What changes were proposed in this pull request?

Added document for CREATE VIEW command.

Why are the changes needed?

As a reference to syntax and examples of CREATE VIEW command.

How was this patch tested?

Documentation update. Verified manually.

@amanomer
[SPARK-28795][DOC] Document CREATE VIEW statement in SQL Reference
693824c 
Changes to be committed:
       modified:   docs/sql-ref-syntax-ddl-create-view.md
@amanomer amanomer changed the title [SPARK-28795][DOC] Document CREATE VIEW statement in SQL Reference [SPARK-28795][DOC][SQL] Document CREATE VIEW statement in SQL Reference Aug 21, 2019
@dilipbiswal
Copy link
Contributor

dilipbiswal commented Aug 21, 2019

@amanomer Could you attach a screenshot of the page ?

srowen
srowen reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. There are a load of other similar PRs to document these things right now. You might compare to the others and a) match their style or what they doc, if it seems appropriate or b) provide reviews on the others to match what you're doing, if it varies.

@amanomer
Copy link
Contributor Author

amanomer commented Aug 22, 2019

@gatorsmile @dilipbiswal kindly review.

@amanomer
[SPARK-28795][DOC][SQL] Document CREATE VIEW statement in SQL reference.
ea803da 
Updated example description, parameters details and related statements.
@dilipbiswal
Copy link
Contributor

dilipbiswal commented Aug 23, 2019 •
edited
Loading

@amanomer Can we reword the description while preserving the semantics. Currently it looks similar to some other docs.

dilipbiswal
dilipbiswal reviewed Aug 23, 2019
View reviewed changes
@amanomer
Copy link
Contributor Author

amanomer commented Aug 23, 2019

cc @dilipbiswal

dilipbiswal
dilipbiswal reviewed Aug 23, 2019
View reviewed changes
dilipbiswal
dilipbiswal reviewed Aug 23, 2019
View reviewed changes
dilipbiswal
dilipbiswal reviewed Aug 23, 2019
View reviewed changes
@dilipbiswal
Copy link
Contributor

dilipbiswal commented Aug 24, 2019

Looks good to me.
@gatorsmile @srowen for final sign off.

@amanomer

This comment has been minimized.

Sign in to view
@amanomer
Copy link
Contributor Author

amanomer commented Sep 6, 2019

cc @dilipbiswal @gatorsmile @srowen

dilipbiswal
dilipbiswal reviewed Sep 6, 2019
View reviewed changes
@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 12, 2019

gentle ping @amanomer

@amanomer
Copy link
Contributor Author

amanomer commented Sep 12, 2019

Working on this. Thanks for your feedback.

@amanomer
Copy link
Contributor Author

amanomer commented Sep 13, 2019

@dilipbiswal Kindly review.

@gatorsmile
Copy link
Member

gatorsmile commented Sep 13, 2019

ok to test

@gatorsmile
Copy link
Member

gatorsmile commented Sep 13, 2019

LGTM after minor editions.

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 13, 2019

Looks good to me. Thanks @gatorsmile

@SparkQA
Copy link

SparkQA commented Sep 13, 2019

Test build #110563 has finished for PR 25543 at commit a3ea519.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented Sep 13, 2019

Thanks! Merged to master.

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 13, 2019

Thank you @gatorsmile

PavithraRamachandran pushed a commit to PavithraRamachandran/spark that referenced this pull request Sep 15, 2019
@amanomer @gatorsmile @PavithraRamachandran
[SPARK-28795][DOC][SQL] Document CREATE VIEW statement in SQL Reference
cb55c14 
### What changes were proposed in this pull request?
Added document for CREATE VIEW command.

### Why are the changes needed?
As a reference to syntax and examples of CREATE VIEW command.

### How was this patch tested?
Documentation update. Verified manually.

Closes apache#25543 from amanomer/spark-28795.

Lead-authored-by: aman_omer <amanomer1996@gmail.com>
Co-authored-by: Xiao Li <gatorsmile@gmail.com>
Co-authored-by: Aman Omer <amanomer1996@gmail.com>
Signed-off-by: Xiao Li <gatorsmile@gmail.com>
@amanomer amanomer deleted the spark-28795 branch September 23, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen left review comments

@dilipbiswal dilipbiswal dilipbiswal left review comments

Assignees

No one assigned

Labels

DOCUMENTATION SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amanomer @dilipbiswal @gatorsmile @SparkQA @srowen @dongjoon-hyun