-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-27521][SQL] Move data source v2 to catalyst module #24416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b961690
4d56a2b
f9b13fb
b8f1316
ab4f40c
c9e00bc
7af4ed1
21ed731
a9eac90
9567cc7
c1b5932
9220e78
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.execution.arrow | ||
package org.apache.spark.sql.util | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't want to add an |
||
|
||
import scala.collection.JavaConverters._ | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -305,7 +305,7 @@ class RateStreamProviderSuite extends StreamTest { | |
.load() | ||
} | ||
assert(exception.getMessage.contains( | ||
"rate source does not support user-specified schema")) | ||
"RateStreamProvider source does not support user-specified schema")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an unrelated change and should be done in a separate commit. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is because I hesitate to move |
||
} | ||
|
||
test("continuous data") { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,7 +204,7 @@ class TextSocketStreamSuite extends StreamTest with SharedSQLContext with Before | |
provider.getTable(new CaseInsensitiveStringMap(params.asJava), userSpecifiedSchema) | ||
} | ||
assert(exception.getMessage.contains( | ||
"socket source does not support user-specified schema")) | ||
"TextSocketSourceProvider source does not support user-specified schema")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. This doesn't need to be done and causes this PR to touch additional files. |
||
} | ||
|
||
test("input row metrics") { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the
ArrowColumnVector
is moved to the catalyst module, I have to move the dependency as well. I think it's fine as sql/core depends on sql/catalyst.