-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-27418][SQL] Migrate Parquet to File Data Source V2 #24327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
...core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetUtils.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.spark.sql.execution.datasources.parquet | ||
|
|
||
| import org.apache.hadoop.fs.{FileStatus, Path} | ||
| import org.apache.parquet.hadoop.ParquetFileWriter | ||
|
|
||
| import org.apache.spark.sql.SparkSession | ||
| import org.apache.spark.sql.types.StructType | ||
|
|
||
| object ParquetUtils { | ||
| def inferSchema( | ||
| sparkSession: SparkSession, | ||
| parameters: Map[String, String], | ||
| files: Seq[FileStatus]): Option[StructType] = { | ||
| val parquetOptions = new ParquetOptions(parameters, sparkSession.sessionState.conf) | ||
|
|
||
| // Should we merge schemas from all Parquet part-files? | ||
| val shouldMergeSchemas = parquetOptions.mergeSchema | ||
|
|
||
| val mergeRespectSummaries = sparkSession.sessionState.conf.isParquetSchemaRespectSummaries | ||
|
|
||
| val filesByType = splitFiles(files) | ||
|
|
||
| // Sees which file(s) we need to touch in order to figure out the schema. | ||
| // | ||
| // Always tries the summary files first if users don't require a merged schema. In this case, | ||
| // "_common_metadata" is more preferable than "_metadata" because it doesn't contain row | ||
| // groups information, and could be much smaller for large Parquet files with lots of row | ||
| // groups. If no summary file is available, falls back to some random part-file. | ||
| // | ||
| // NOTE: Metadata stored in the summary files are merged from all part-files. However, for | ||
| // user defined key-value metadata (in which we store Spark SQL schema), Parquet doesn't know | ||
| // how to merge them correctly if some key is associated with different values in different | ||
| // part-files. When this happens, Parquet simply gives up generating the summary file. This | ||
| // implies that if a summary file presents, then: | ||
| // | ||
| // 1. Either all part-files have exactly the same Spark SQL schema, or | ||
| // 2. Some part-files don't contain Spark SQL schema in the key-value metadata at all (thus | ||
| // their schemas may differ from each other). | ||
| // | ||
| // Here we tend to be pessimistic and take the second case into account. Basically this means | ||
| // we can't trust the summary files if users require a merged schema, and must touch all part- | ||
| // files to do the merge. | ||
| val filesToTouch = | ||
| if (shouldMergeSchemas) { | ||
| // Also includes summary files, 'cause there might be empty partition directories. | ||
|
|
||
| // If mergeRespectSummaries config is true, we assume that all part-files are the same for | ||
| // their schema with summary files, so we ignore them when merging schema. | ||
| // If the config is disabled, which is the default setting, we merge all part-files. | ||
| // In this mode, we only need to merge schemas contained in all those summary files. | ||
| // You should enable this configuration only if you are very sure that for the parquet | ||
| // part-files to read there are corresponding summary files containing correct schema. | ||
|
|
||
| // As filed in SPARK-11500, the order of files to touch is a matter, which might affect | ||
| // the ordering of the output columns. There are several things to mention here. | ||
| // | ||
| // 1. If mergeRespectSummaries config is false, then it merges schemas by reducing from | ||
| // the first part-file so that the columns of the lexicographically first file show | ||
| // first. | ||
| // | ||
| // 2. If mergeRespectSummaries config is true, then there should be, at least, | ||
| // "_metadata"s for all given files, so that we can ensure the columns of | ||
| // the lexicographically first file show first. | ||
| // | ||
| // 3. If shouldMergeSchemas is false, but when multiple files are given, there is | ||
| // no guarantee of the output order, since there might not be a summary file for the | ||
| // lexicographically first file, which ends up putting ahead the columns of | ||
| // the other files. However, this should be okay since not enabling | ||
| // shouldMergeSchemas means (assumes) all the files have the same schemas. | ||
|
|
||
| val needMerged: Seq[FileStatus] = | ||
| if (mergeRespectSummaries) { | ||
| Seq.empty | ||
| } else { | ||
| filesByType.data | ||
| } | ||
| needMerged ++ filesByType.metadata ++ filesByType.commonMetadata | ||
| } else { | ||
| // Tries any "_common_metadata" first. Parquet files written by old versions or Parquet | ||
| // don't have this. | ||
| filesByType.commonMetadata.headOption | ||
| // Falls back to "_metadata" | ||
| .orElse(filesByType.metadata.headOption) | ||
| // Summary file(s) not found, the Parquet file is either corrupted, or different part- | ||
| // files contain conflicting user defined metadata (two or more values are associated | ||
| // with a same key in different files). In either case, we fall back to any of the | ||
| // first part-file, and just assume all schemas are consistent. | ||
| .orElse(filesByType.data.headOption) | ||
| .toSeq | ||
| } | ||
| ParquetFileFormat.mergeSchemasInParallel(filesToTouch, sparkSession) | ||
| } | ||
|
|
||
| case class FileTypes( | ||
| data: Seq[FileStatus], | ||
| metadata: Seq[FileStatus], | ||
| commonMetadata: Seq[FileStatus]) | ||
|
|
||
| private def splitFiles(allFiles: Seq[FileStatus]): FileTypes = { | ||
| val leaves = allFiles.toArray.sortBy(_.getPath.toString) | ||
|
|
||
| FileTypes( | ||
| data = leaves.filterNot(f => isSummaryFile(f.getPath)), | ||
| metadata = | ||
| leaves.filter(_.getPath.getName == ParquetFileWriter.PARQUET_METADATA_FILE), | ||
| commonMetadata = | ||
| leaves.filter(_.getPath.getName == ParquetFileWriter.PARQUET_COMMON_METADATA_FILE)) | ||
| } | ||
|
|
||
| private def isSummaryFile(file: Path): Boolean = { | ||
| file.getName == ParquetFileWriter.PARQUET_COMMON_METADATA_FILE || | ||
| file.getName == ParquetFileWriter.PARQUET_METADATA_FILE | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.