[SPARK-3566] [BUILD] .gitignore and .rat-excludes should consider Windows cmd file and Emacs' backup files

[sarutak]

No description provided.

[SparkQA]

QA tests have started for PR 2426 at commit 6a0a5eb.

• This patch merges cleanly.

[ScrapCodes]

You can have global gitignore. https://help.github.com/articles/ignoring-files. I am not sure how many editors and such we are going to support. Mind closing this PR.

[sarutak]

@ScrapCodes Thanks for your comment.
Vim/vi and Emacs are the most popular editors and current .gitignore considers vim's swp file so Emacs should be considered.

Also, this PR includes the modification for Windows batch file so I cannot close this PR, sorry.

[ScrapCodes]

There is nothing like spark-env.cmd in the code base ? + Emacs is my editor of choice too and I add those excludes in gitignore global simply because I can not go and update gitignore on every open source project I work on.

[sarutak]

Current code base doesn't include spark-env.sh but user can create and used by spark-class2.cmd, run-examples2.cmd, compute-classpath.cmd and pyspark2.cmd.

And if applying your logic, the entry for swp should be removed from .gitignore.

[SparkQA]

Tests timed out after a configured wait of 120m.

[sarutak]

retest this please.

[SparkQA]

QA tests have started for PR 2426 at commit 6a0a5eb.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2426 at commit 6a0a5eb.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class ArrayConstructor extends net.razorvine.pickle.objects.ArrayConstructor
  • class NonASCIICharacterChecker extends ScalariformChecker
  • class RatingDeserializer(FramedSerializer):
  • class SCCallSiteSync(object):
  • class Encoder[T <: NativeType](columnType: NativeColumnType[T]) extends compression.Encoder[T]
  • class Encoder[T <: NativeType](columnType: NativeColumnType[T]) extends compression.Encoder[T]
  • class Encoder[T <: NativeType](columnType: NativeColumnType[T]) extends compression.Encoder[T]
  • class Encoder extends compression.Encoder[IntegerType.type]
  • class Decoder(buffer: ByteBuffer, columnType: NativeColumnType[IntegerType.type])
  • class Encoder extends compression.Encoder[LongType.type]
  • class Decoder(buffer: ByteBuffer, columnType: NativeColumnType[LongType.type])

[SparkQA]

QA tests have started for PR 2426 at commit a306020.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2426 at commit a306020.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[pwendell]

This seems fine to me. For very common file editors seems okay to support them.