Skip to content

[SPARK-3540] Add reboot-slaves functionality to the ec2 script #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Sep 16, 2014

Tested on a real cluster.

(cherry picked from commit 9aaad3c)
Signed-off-by: Reynold Xin <rxin@apache.org>
@SparkQA
Copy link

SparkQA commented Sep 16, 2014

QA tests have started for PR 2404 at commit 00a2dbd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 16, 2014

QA tests have finished for PR 2404 at commit 00a2dbd.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ArrayConstructor extends net.razorvine.pickle.objects.ArrayConstructor

@shivaram
Copy link
Contributor

LGTM

@rxin
Copy link
Contributor Author

rxin commented Sep 16, 2014

@ScrapCodes any idea why random public classes are being reported, even though they have nothing to do with this PR?

@rxin
Copy link
Contributor Author

rxin commented Sep 16, 2014

Merging in master. Thanks.

@asfgit asfgit closed this in d428ac6 Sep 16, 2014
@ScrapCodes
Copy link
Member

It happens because in the git diff the script compares the PR branch with master and if PR is not rebased to the tip of master. False reporting will happen.

@ScrapCodes
Copy link
Member

So I guess it came from the commit, da33acb. But this seems to be present in your branch. So may be I will have to dig deeper.

@nchammas
Copy link
Contributor

It happens because in the git diff the script compares the PR branch with master and if PR is not rebased to the tip of master. False reporting will happen.

Won't those changes show up as removed lines though? The script that posts these new classes filters in only added lines.

@nchammas
Copy link
Contributor

Actually, I guess if a class was removed from master but not also removed from the PR fork, then that would show up as an added class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants