-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[Minor]ignore all config files in conf #2395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
Jenkins, test this please. |
LGTM pending tests. |
QA tests have started for PR 2395 at commit
|
QA tests have finished for PR 2395 at commit
|
@scwf Thanks for your work!
|
@sarutak , i think we should not add them to .gitignore, this files is the sample file we show to users, in future devs may change them according to updating of master branch. |
@scwf Ah, exactly, .template is just a sample. But slaves is a kind of confs right? |
@sarutak , ok, i will add it |
Hang on, that file is versioned in the repo. I don't think you want to ignore it! Not without deciding it should be deleted. |
yeah, @sarutak, ignore slaves means that it will not be versioned, so not ignore it |
O.K. I got it. |
@srowen was your comment about something in the current patch or proposed in one of the comments? Does this LGTY? |
I was commenting on a comment, suggesting to also ignore conf/slaves. It is not in the PR so LGTM. |
Jenkins LGTM. |
Jenkins, test this please. |
LGTMT |
Jenkins, test this please. |
QA tests have started for PR 2395 at commit
|
QA tests have started for PR 2395 at commit
|
QA tests have finished for PR 2395 at commit
|
QA tests have finished for PR 2395 at commit
|
Merged, thanks. |
Some config files in
conf
should ignore, such asconf/fairscheduler.xml
conf/hive-log4j.properties
conf/metrics.properties
...
So ignore all
sh
/properties
/conf
/xml
files