[SPARK-27007][PYTHON]add rawPrediction to OneVsRest in PySpark #23910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #102831 has finished for PR 23910 at commit
|
|
Test build #102836 has finished for PR 23910 at commit
|
|
Test build #102838 has finished for PR 23910 at commit
|
srowen
requested changes
Feb 28, 2019
python/pyspark/sql/dataframe.py
Outdated
| @@ -1980,6 +1980,29 @@ def withColumn(self, colName, col): | |||
| assert isinstance(col, Column), "col should be Column" | |||
| return DataFrame(self._jdf.withColumn(colName, col._jc), self.sql_ctx) | |||
|
|
|||
| @ignore_unicode_prefix | |||
| def withColumns(self, colNames, cols): | |||
There was a problem hiding this comment.
It looks like the Scala impl has this method, but it's not exposed. Instead of adding it here, can you just use two calls to withColumn above?
|
Test build #102924 has finished for PR 23910 at commit
|
srowen
approved these changes
Mar 1, 2019
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add RawPrediction to OneVsRest in PySpark to make it consistent with scala implementation
How was this patch tested?
Add doctest