[SPARK-26952][SQL] Row count statics should respect the data reported by data source #23853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @cloud-fan would you mind taking a look? Thanks in advance. |
|
ok to test |
|
Test build #102585 has finished for PR 23853 at commit
|
cloud-fan
reviewed
Feb 22, 2019
| } else { | ||
| None | ||
| } | ||
| Statistics( |
There was a problem hiding this comment.
shall we create a util method to turn v2 statistics to spark statistics?
There was a problem hiding this comment.
OK, will add it later.
|
Test build #102776 has finished for PR 23853 at commit
|
|
thanks, merging to master! |
|
Thanks @cloud-fan. |
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
May 15, 2019
… by data source ## What changes were proposed in this pull request? In data source v2, if the data source scan implemented `SupportsReportStatistics`. `DataSourceV2Relation` should respect the row count reported by the data source. ## How was this patch tested? New UT test. Closes apache#23853 from ConeyLiu/report-row-count. Authored-by: Xianyang Liu <xianyang.liu@intel.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In data source v2, if the data source scan implemented
SupportsReportStatistics.DataSourceV2Relationshould respect the row count reported by the data source.How was this patch tested?
New UT test.