[SPARK-3518] Remove wasted statement in JsonProtocol #2380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 2380 at commit
|
| @@ -217,7 +219,7 @@ private[spark] object JsonProtocol { | |||
| ("Getting Result Time" -> taskInfo.gettingResultTime) ~ | |||
| ("Finish Time" -> taskInfo.finishTime) ~ | |||
| ("Failed" -> taskInfo.failed) ~ | |||
| ("Accumulables" -> JArray(taskInfo.accumulables.map(accumulableInfoToJson).toList)) | |||
| ("Accumulables" -> JArray(accumUpdateMap.map(accumulableInfoToJson).toList)) | |||
There was a problem hiding this comment.
Why not just remove the unused accumUpdateMap instead and preserve the symmetry? This is a simple getter, which would be inlined anyway. This also seems very trivial.
|
QA tests have started for PR 2380 at commit
|
|
QA tests have started for PR 2380 at commit
|
|
QA tests have finished for PR 2380 at commit
|
|
QA tests have finished for PR 2380 at commit
|
|
QA tests have finished for PR 2380 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Sep 15, 2014
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closes #2380 from sarutak/SPARK-3518 and squashes the following commits: 8a1464e [Kousuke Saruta] Replaced a variable with simple field reference c660fbc [Kousuke Saruta] Removed useless statement in JsonProtocol.scala (cherry picked from commit e59fac1) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
markhamstra
pushed a commit
to markhamstra/spark
that referenced
this pull request
Sep 19, 2014
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closes apache#2380 from sarutak/SPARK-3518 and squashes the following commits: 8a1464e [Kousuke Saruta] Replaced a variable with simple field reference c660fbc [Kousuke Saruta] Removed useless statement in JsonProtocol.scala (cherry picked from commit e59fac1) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.