Conversation
nchammas
commented
Sep 12, 2014
nchammas
commented
- Fixed random typo
- Added in missing description for DecimalType
* Fixed random typo * Added in description for BigDecimal
docs/sql-programming-guide.md
Outdated
There was a problem hiding this comment.
I'm not 100% sure about this, actually, but the description is obviously missing.
There was a problem hiding this comment.
Represents arbitrary-precision signed decimal numbers. A BigDecimal consists of an arbitrary precision integer unscaled value and a 32-bit integer scale. Backed internally by java.math.BigDecimal.
There was a problem hiding this comment.
Did you mean "A DecimalType consists of..."?
There was a problem hiding this comment.
Or perhaps a reordering of the sentences as such?
Represents arbitrary-precision signed decimal numbers. Backed internally by java.math.BigDecimal. A BigDecimal consists of an arbitrary precision integer unscaled value and a 32-bit integer scale.
There was a problem hiding this comment.
Okie doke. Done. (the latter way)
|
@marmbrus - These things should probably also be fixed in the just-released 1.1.0 docs: |
|
QA tests have started for PR 2367 at commit
|
|
QA tests have finished for PR 2367 at commit
|
Per @marmbrus’s instructions here: apache#2367 (comment)
|
QA tests have started for PR 2367 at commit
|
|
QA tests have finished for PR 2367 at commit
|
|
@marmbrus Is this PR good to go? I'd be happy to update it or close it as required. |
|
Thanks! Merged. |
* Fixed random typo * Added in missing description for DecimalType Author: Nicholas Chammas <nicholas.chammas@gmail.com> Closes #2367 from nchammas/patch-1 and squashes the following commits: aa528be [Nicholas Chammas] doc fix for SQL DecimalType 3247ac1 [Nicholas Chammas] [SQL] [Docs] typo fixes (cherry picked from commit a523cea) Signed-off-by: Michael Armbrust <michael@databricks.com>
3 participants
