[SPARK-26599][SQL]BroardCast hint can not work with PruneFileSourcePartitions #23517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BroardCast hint can not work with
PruneFileSourcePartitions
, for example, when the filter condition p is a partition field, table b in SQL below cannot be broadcast.sql("select /*+ broadcastjoin(b) */ * from (select a from empty_test where p=1) a " + "join (select a,b from par_1 where p=1) b on a.a=b.a").explain
The reason is that
PruneFileSourcePartitions
deletedResolvedHint
when matchingPhysicalOperations
, the plan afterPruneFileSourcePartitions
before this PR is:The original reason for this problem is that when
PhysicalOperation
matches ResolvedHint, it returns directly to its child nodes and skips over itself.case h: ResolvedHint => collectProjectsAndFilters(h.child)
This PR adds processing to
ResolvedHint
, when matched to it inPruneFileSourcePartitions
, skip it directly and parse its child nodes.How was this patch tested?
Unit test of
PruneFileSourcePartitionsSuite