-
Notifications
You must be signed in to change notification settings - Fork 28.5k
[SPARK-3516] [mllib] DecisionTree: Add minInstancesPerNode, minInfoGain params to example and Python API #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rune Conflicts: mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
…unner.scala and to Python API in tree.py
…tisfy min instance per node requirements" * small style fixes
QA tests have started for PR 2349 at commit
|
QA tests have started for PR 2349 at commit
|
QA tests have finished for PR 2349 at commit
|
QA tests have finished for PR 2349 at commit
|
test("don't choose split that doesn't satisfy min instance per node requirements") { | ||
// if a split doesn't satisfy min instances per node requirements, | ||
test("do not choose split that does not satisfy min instance per node requirements") { | ||
// if a split does not satisfy min instances per node requirements, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "don't" is typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a typo. But I figured that, if people are munging logs from tests, quote characters might be troublesome to deal with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds reasonable, thanks.
This patch looks good to me, just one minor question. |
@davies Thanks for taking a look! |
@jkbradley This contains API changes to python. Could you create a JIRA for it? Thanks! |
Conflicts: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala
QA tests have started for PR 2349 at commit
|
QA tests have started for PR 2349 at commit
|
QA tests have finished for PR 2349 at commit
|
Unrelated failure (in streaming) |
QA tests have finished for PR 2349 at commit
|
@mengxr This patch should be ready to check now. Thanks! |
LGTM. Merged into master. Thanks! |
Added minInstancesPerNode, minInfoGain params to:
Also:
CC: @mengxr