Skip to content

[SPARK-3516] [mllib] DecisionTree: Add minInstancesPerNode, minInfoGain params to example and Python API #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from

Conversation

jkbradley
Copy link
Member

Added minInstancesPerNode, minInfoGain params to:

  • DecisionTreeRunner.scala example
  • Python API (tree.py)

Also:

  • Fixed typo in tree suite test "do not choose split that does not satisfy min instance per node requirements"
  • small style fixes

CC: @mengxr

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have started for PR 2349 at commit 95c479d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have started for PR 2349 at commit 95c479d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have finished for PR 2349 at commit 95c479d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have finished for PR 2349 at commit 95c479d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

test("don't choose split that doesn't satisfy min instance per node requirements") {
// if a split doesn't satisfy min instances per node requirements,
test("do not choose split that does not satisfy min instance per node requirements") {
// if a split does not satisfy min instances per node requirements,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "don't" is typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a typo. But I figured that, if people are munging logs from tests, quote characters might be troublesome to deal with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds reasonable, thanks.

@davies
Copy link
Contributor

davies commented Sep 11, 2014

This patch looks good to me, just one minor question.

@jkbradley
Copy link
Member Author

@davies Thanks for taking a look!

@mengxr
Copy link
Contributor

mengxr commented Sep 12, 2014

@jkbradley This contains API changes to python. Could you create a JIRA for it? Thanks!

Conflicts:
	mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala
@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2349 at commit a95e7c8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2349 at commit 61b2e72.

  • This patch merges cleanly.

@jkbradley jkbradley changed the title [mllib] DecisionTree: Add minInstancesPerNode, minInfoGain params to example and Python API [SPARK-3516] [mllib] DecisionTree: Add minInstancesPerNode, minInfoGain params to example and Python API Sep 13, 2014
@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2349 at commit a95e7c8.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • throw new IllegalStateException("The main method in the given main class must be static")

@jkbradley
Copy link
Member Author

Unrelated failure (in streaming)

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2349 at commit 61b2e72.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • throw new IllegalStateException("The main method in the given main class must be static")

@jkbradley
Copy link
Member Author

@mengxr This patch should be ready to check now. Thanks!

@mengxr
Copy link
Contributor

mengxr commented Sep 16, 2014

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in fdb302f Sep 16, 2014
@jkbradley jkbradley deleted the chouqin-dt-preprune branch October 8, 2014 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants