[SPARK-26526][SQL][TEST] Fix invalid test case about non-deterministic expression #23440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan , this pr fixes issue in #8486 (comment) |
cloud-fan
reviewed
Jan 3, 2019
| @@ -1398,11 +1398,15 @@ class DataFrameSuite extends QueryTest with SharedSQLContext { | |||
| } | |||
|
|
|||
| test("SPARK-10316: respect non-deterministic expressions in PhysicalOperation") { | |||
| val input = spark.read.json((1 to 10).map(i => s"""{"id": $i}""").toDS()) | |||
| withTempDir { dir => | |||
| val tempJsonFile = new File(dir, "tmp_json") | |||
There was a problem hiding this comment.
we can use withTempPath and write to the path directly.
|
ok to test |
|
Test build #100698 has finished for PR 23440 at commit
|
|
thanks, merging to master! |
|
Test build #100713 has finished for PR 23440 at commit
|
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…c expression ## What changes were proposed in this pull request? Test case in SPARK-10316 is used to make sure non-deterministic `Filter` won't be pushed through `Project` But in current code base this test case can't cover this purpose. Change LogicalRDD to HadoopFsRelation can fix this issue. ## How was this patch tested? Modified test pass. Closes apache#23440 from LinhongLiu/fix-test. Authored-by: Liu,Linhong <liulinhong@baidu.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test case in SPARK-10316 is used to make sure non-deterministic
Filterwon't be pushed throughProjectBut in current code base this test case can't cover this purpose.
Change LogicalRDD to HadoopFsRelation can fix this issue.
How was this patch tested?
Modified test pass.