Skip to content

Conversation

@kjmrknsn
Copy link
Contributor

@kjmrknsn kjmrknsn commented Nov 26, 2018

What changes were proposed in this pull request?

Fix Typos.

How was this patch tested?

NA

@HyukjinKwon
Copy link
Member

It's okay but mind taking another look the documentation and fix other typos while we are here? I'm pretty sure there are more.

@kjmrknsn
Copy link
Contributor Author

OK, I'll check the whole documentation later. Thanks.

docs/index.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I'm not sure this should be called "an experimental [R API]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the "experimental" adjective?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove experimental, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjmrknsn kjmrknsn changed the title [MINOR][Docs] "a R interpreter" -> "an R interpreter" [MINOR][Docs][] "a R interpreter" -> "an R interpreter" Nov 27, 2018
@kjmrknsn kjmrknsn changed the title [MINOR][Docs][] "a R interpreter" -> "an R interpreter" [MINOR][Docs][WIP] Fix Typos Nov 27, 2018
@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Nov 27, 2018

Test build #99331 has finished for PR 23145 at commit b43b9ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kjmrknsn
Copy link
Contributor Author

Sorry, this PR is still WIP. I'll continue to check the documentation later. Thanks.

@SparkQA
Copy link

SparkQA commented Nov 28, 2018

Test build #99344 has finished for PR 23145 at commit eeb1c83.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

- *Query name:* Optionally, specify a unique name of the query for identification.

- *Trigger interval:* Optionally, specify the trigger interval. If it is not specified, the system will check for availability of new data as soon as the previous processing has completed. If a trigger time is missed because the previous processing has not completed, then the system will trigger processing immediately.
- *Trigger interval:* Optionally, specify the trigger interval. If it is not specified, the system will check for availability of new data as soon as the previous processing has been completed. If a trigger time is missed because the previous processing has not been completed, then the system will trigger processing immediately.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"has completed" is actually correct, but the passive voice here is grammatical too.

@srowen
Copy link
Member

srowen commented Nov 29, 2018

I think this is fine to merge, this is a good batch of grammar fixes.

@asfgit asfgit closed this in de42281 Nov 29, 2018
@kjmrknsn
Copy link
Contributor Author

Thanks for reviewing and merging.
I've just finished checking the whole documentation.
Here is the complete version of this PR : #23185
Thanks.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?
Fix Typos.

## How was this patch tested?
NA

Closes apache#23145 from kjmrknsn/docUpdate.

Authored-by: Keiji Yoshida <kjmrknsn@gmail.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?
Fix Typos.
This PR is the complete version of apache#23145.

## How was this patch tested?
NA

Closes apache#23185 from kjmrknsn/docUpdate.

Authored-by: Keiji Yoshida <kjmrknsn@gmail.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants