-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][Docs][WIP] Fix Typos #23145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][Docs][WIP] Fix Typos #23145
Conversation
|
It's okay but mind taking another look the documentation and fix other typos while we are here? I'm pretty sure there are more. |
|
OK, I'll check the whole documentation later. Thanks. |
docs/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, I'm not sure this should be called "an experimental [R API]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the "experimental" adjective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove experimental, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, experimental has been removed. https://github.com/apache/spark/pull/23145/files#diff-1a523bd9fa0dbf998008b37579210e12
|
ok to test |
|
Test build #99331 has finished for PR 23145 at commit
|
|
Sorry, this PR is still WIP. I'll continue to check the documentation later. Thanks. |
|
Test build #99344 has finished for PR 23145 at commit
|
| - *Query name:* Optionally, specify a unique name of the query for identification. | ||
|
|
||
| - *Trigger interval:* Optionally, specify the trigger interval. If it is not specified, the system will check for availability of new data as soon as the previous processing has completed. If a trigger time is missed because the previous processing has not completed, then the system will trigger processing immediately. | ||
| - *Trigger interval:* Optionally, specify the trigger interval. If it is not specified, the system will check for availability of new data as soon as the previous processing has been completed. If a trigger time is missed because the previous processing has not been completed, then the system will trigger processing immediately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"has completed" is actually correct, but the passive voice here is grammatical too.
|
I think this is fine to merge, this is a good batch of grammar fixes. |
|
Thanks for reviewing and merging. |
## What changes were proposed in this pull request? Fix Typos. ## How was this patch tested? NA Closes apache#23145 from kjmrknsn/docUpdate. Authored-by: Keiji Yoshida <kjmrknsn@gmail.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
## What changes were proposed in this pull request? Fix Typos. This PR is the complete version of apache#23145. ## How was this patch tested? NA Closes apache#23185 from kjmrknsn/docUpdate. Authored-by: Keiji Yoshida <kjmrknsn@gmail.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
What changes were proposed in this pull request?
Fix Typos.
How was this patch tested?
NA