Skip to content

[SPARK-25901][CORE] Use only one thread in BarrierTaskContext companion object #22912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-25901][CORE] Use only one thread in BarrierTaskContext companion object #22912

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adfcf3f
send timer to the companion object
yogeshg Oct 31, 2018
6c8719a
TO REVERT; make logging 1 second for testing
yogeshg Oct 31, 2018
2f2de0b
Revert "TO REVERT; make logging 1 second for testing"
yogeshg Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/src/main/scala/org/apache/spark/BarrierTaskContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ import org.apache.spark.util._
class BarrierTaskContext private[spark] (
taskContext: TaskContext) extends TaskContext with Logging {

import BarrierTaskContext._

// Find the driver side RPCEndpointRef of the coordinator that handles all the barrier() calls.
private val barrierCoordinator: RpcEndpointRef = {
val env = SparkEnv.get
RpcUtils.makeDriverRef("barrierSync", env.conf, env.rpcEnv)
}

private val timer = new Timer("Barrier task timer for barrier() calls.")

// Local barrierEpoch that identify a barrier() call from current task, it shall be identical
// with the driver side epoch.
private var barrierEpoch = 0
Expand Down Expand Up @@ -234,4 +234,7 @@ object BarrierTaskContext {
@Experimental
@Since("2.4.0")
def get(): BarrierTaskContext = TaskContext.get().asInstanceOf[BarrierTaskContext]

private val timer = new Timer("Barrier task timer for barrier() calls.")

}