-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-3417] -Use new-style classes in PySpark #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good catch! While you're at it, are there any other old-style classes in PySpark that should be made into new-style ones? |
Also, do you mind opening a JIRA ticket on https://issues.apache.org/jira/browse/SPARK and editing the title of your pull request to reference it, e.g. |
Sure. Next time I find a few free minutes. On Fri, Sep 5, 2014 at 8:04 AM, Josh Rosen notifications@github.com wrote:
|
|
Done |
The title is a bit confusing, would you mind to change it to "Use new-style classes in PySpark" ? The patch looks good to me, thanks! |
done |
Can one of the admins verify this patch? |
Jenkins, this is ok to test. |
Jenkins, test this please. |
Jenkins, this is ok to test. Jenkins, retest this please. |
QA tests have started for PR 2288 at commit
|
QA tests have finished for PR 2288 at commit
|
Jenkins, retest this please. (want to see how long it takes Jenkins to respond to me...) |
He's been pretty slow to respond lately. 10-15 min I'd say. |
Looks like this only failed unrelated streaming tests ( I'm going to merge this to master. |
Tiny PR making SQLContext a new-style class. This allows various type logic to work more effectively