Skip to content

[SPARK-3417] -Use new-style classes in PySpark #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mrocklin
Copy link
Contributor

@mrocklin mrocklin commented Sep 5, 2014

Tiny PR making SQLContext a new-style class. This allows various type logic to work more effectively

In [1]: import pyspark

In [2]: pyspark.sql.SQLContext.mro()
Out[2]: [pyspark.sql.SQLContext, object]

@JoshRosen
Copy link
Contributor

Good catch! While you're at it, are there any other old-style classes in PySpark that should be made into new-style ones?

@JoshRosen
Copy link
Contributor

Also, do you mind opening a JIRA ticket on https://issues.apache.org/jira/browse/SPARK and editing the title of your pull request to reference it, e.g. [SPARK-xxxx] Use new-style classes in PySpark?

@mrocklin
Copy link
Contributor Author

mrocklin commented Sep 5, 2014

Sure. Next time I find a few free minutes.

On Fri, Sep 5, 2014 at 8:04 AM, Josh Rosen notifications@github.com wrote:

Also, do you mind opening a JIRA ticket on
https://issues.apache.org/jira/browse/SPARK and editing the title of your
pull request to reference it, e.g. [SPARK-xxxx] Use new-style classes in
PySpark?


Reply to this email directly or view it on GitHub
#2288 (comment).

@mrocklin
Copy link
Contributor Author

mrocklin commented Sep 5, 2014

mrocklin@notebook:~/workspace/spark$ git grep "^class \w*:"
mrocklin@notebook:~/workspace/spark$ 

@mrocklin mrocklin changed the title pyspark.sql.SQLContext is new-style class [SPARK-3417] -Use of old-style classes in pyspark Sep 5, 2014
@mrocklin
Copy link
Contributor Author

mrocklin commented Sep 5, 2014

Done

@davies
Copy link
Contributor

davies commented Sep 5, 2014

The title is a bit confusing, would you mind to change it to "Use new-style classes in PySpark" ?

The patch looks good to me, thanks!

@mrocklin mrocklin changed the title [SPARK-3417] -Use of old-style classes in pyspark [SPARK-3417] -Use new-style classes in PySpark Sep 5, 2014
@mrocklin
Copy link
Contributor Author

mrocklin commented Sep 5, 2014

done

@SparkQA
Copy link

SparkQA commented Sep 5, 2014

Can one of the admins verify this patch?

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@davies
Copy link
Contributor

davies commented Sep 6, 2014

Jenkins, test this please.

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test. Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Sep 6, 2014

QA tests have started for PR 2288 at commit 4aadab6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 6, 2014

QA tests have finished for PR 2288 at commit 4aadab6.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RandomRDDs(object):
    • class MLUtils(object):
    • class SQLContext(object):
    • class StorageLevel(object):

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

(want to see how long it takes Jenkins to respond to me...)

@nchammas
Copy link
Contributor

nchammas commented Sep 6, 2014

He's been pretty slow to respond lately. 10-15 min I'd say.

@marmbrus
Copy link
Contributor

marmbrus commented Sep 8, 2014

Looks like this only failed unrelated streaming tests (Exception encountered when attempting to run a suite with class name: org.apache.spark.streaming.kafka.KafkaStreamSuite) /cc @tdas.

I'm going to merge this to master.

@asfgit asfgit closed this in 939a322 Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants