-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-25865][CORE] Add GC information to ExecutorMetrics #22874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6ad48d6
[SPARK-25865][CORE] Add GC information to ExecutorMetrics
LantaoJin b8c3382
add UT
LantaoJin 098a246
address comments
LantaoJin 1dbc68a
address comments
LantaoJin 94fd962
make configurable
LantaoJin e4d9acd
address comments
LantaoJin aa3cf3c
address comments
LantaoJin 544749d
address comments
LantaoJin fe5a04c
address rat check
LantaoJin 12fc5cc
address comments
LantaoJin 6d5643c
remove the unclear gc metric configuration
LantaoJin 4d1021c
fix ut
LantaoJin ba500fe
address the comments
LantaoJin 958a728
make log clear
LantaoJin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
core/src/test/resources/HistoryServerExpectations/application_list_json_expectation.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
...Expectations/executor_list_with_executor_garbage_collection_metrics_json_expectation.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| [ { | ||
| "id" : "driver", | ||
| "hostPort" : "047.company.com:42509", | ||
| "isActive" : true, | ||
| "rddBlocks" : 0, | ||
| "memoryUsed" : 0, | ||
| "diskUsed" : 0, | ||
| "totalCores" : 0, | ||
| "maxTasks" : 0, | ||
| "activeTasks" : 0, | ||
| "failedTasks" : 0, | ||
| "completedTasks" : 0, | ||
| "totalTasks" : 0, | ||
| "totalDuration" : 0, | ||
| "totalGCTime" : 0, | ||
| "totalInputBytes" : 0, | ||
| "totalShuffleRead" : 0, | ||
| "totalShuffleWrite" : 0, | ||
| "isBlacklisted" : false, | ||
| "maxMemory" : 100977868, | ||
| "addTime" : "2019-01-08T04:33:44.502GMT", | ||
| "executorLogs" : { | ||
| "stdout" : "https://047.company.com:50060/node/containerlogs/container_e136_1536831636016_59384_01_000001/lajin/stdout?start=-4096", | ||
| "stderr" : "https://047.company.com:50060/node/containerlogs/container_e136_1536831636016_59384_01_000001/lajin/stderr?start=-4096" | ||
| }, | ||
| "memoryMetrics" : { | ||
| "usedOnHeapStorageMemory" : 0, | ||
| "usedOffHeapStorageMemory" : 0, | ||
| "totalOnHeapStorageMemory" : 100977868, | ||
| "totalOffHeapStorageMemory" : 0 | ||
| }, | ||
| "blacklistedInStages" : [ ], | ||
| "peakMemoryMetrics" : { | ||
| "JVMHeapMemory" : 211171816, | ||
| "JVMOffHeapMemory" : 90237256, | ||
| "OnHeapExecutionMemory" : 0, | ||
| "OffHeapExecutionMemory" : 0, | ||
| "OnHeapStorageMemory" : 4876, | ||
| "OffHeapStorageMemory" : 0, | ||
| "OnHeapUnifiedMemory" : 4876, | ||
| "OffHeapUnifiedMemory" : 0, | ||
| "DirectPoolMemory" : 806275, | ||
| "MappedPoolMemory" : 0, | ||
| "ProcessTreeJVMVMemory" : 2646888448, | ||
| "ProcessTreeJVMRSSMemory" : 520900608, | ||
| "ProcessTreePythonVMemory" : 0, | ||
| "ProcessTreePythonRSSMemory" : 0, | ||
| "ProcessTreeOtherVMemory" : 0, | ||
| "ProcessTreeOtherRSSMemory" : 0, | ||
| "MinorGCCount" : 8, | ||
| "MinorGCTime" : 374, | ||
| "MajorGCCount" : 3, | ||
| "MajorGCTime" : 170 | ||
| }, | ||
| "attributes" : { } | ||
| }, { | ||
| "id" : "2", | ||
| "hostPort" : "028.company.com:46325", | ||
| "isActive" : true, | ||
| "rddBlocks" : 0, | ||
| "memoryUsed" : 0, | ||
| "diskUsed" : 0, | ||
| "totalCores" : 4, | ||
| "maxTasks" : 4, | ||
| "activeTasks" : 0, | ||
| "failedTasks" : 0, | ||
| "completedTasks" : 52, | ||
| "totalTasks" : 52, | ||
| "totalDuration" : 8879, | ||
| "totalGCTime" : 420, | ||
| "totalInputBytes" : 0, | ||
| "totalShuffleRead" : 0, | ||
| "totalShuffleWrite" : 0, | ||
| "isBlacklisted" : false, | ||
| "maxMemory" : 97832140, | ||
| "addTime" : "2019-01-08T04:33:54.270GMT", | ||
| "executorLogs" : { | ||
| "stdout" : "https://028.company.com:50060/node/containerlogs/container_e136_1536831636016_59384_01_000003/lajin/stdout?start=-4096", | ||
| "stderr" : "https://028.company.com:50060/node/containerlogs/container_e136_1536831636016_59384_01_000003/lajin/stderr?start=-4096" | ||
| }, | ||
| "memoryMetrics" : { | ||
| "usedOnHeapStorageMemory" : 0, | ||
| "usedOffHeapStorageMemory" : 0, | ||
| "totalOnHeapStorageMemory" : 97832140, | ||
| "totalOffHeapStorageMemory" : 0 | ||
| }, | ||
| "blacklistedInStages" : [ ], | ||
| "attributes" : { } | ||
| }, { | ||
| "id" : "1", | ||
| "hostPort" : "036.company.com:35126", | ||
| "isActive" : true, | ||
| "rddBlocks" : 0, | ||
| "memoryUsed" : 0, | ||
| "diskUsed" : 0, | ||
| "totalCores" : 4, | ||
| "maxTasks" : 4, | ||
| "activeTasks" : 0, | ||
| "failedTasks" : 0, | ||
| "completedTasks" : 48, | ||
| "totalTasks" : 48, | ||
| "totalDuration" : 8837, | ||
| "totalGCTime" : 1192, | ||
| "totalInputBytes" : 0, | ||
| "totalShuffleRead" : 0, | ||
| "totalShuffleWrite" : 0, | ||
| "isBlacklisted" : false, | ||
| "maxMemory" : 97832140, | ||
| "addTime" : "2019-01-08T04:33:55.929GMT", | ||
| "executorLogs" : { | ||
| "stdout" : "https://036.company.com:50060/node/containerlogs/container_e136_1536831636016_59384_01_000002/lajin/stdout?start=-4096", | ||
| "stderr" : "https://036.company.com:50060/node/containerlogs/container_e136_1536831636016_59384_01_000002/lajin/stderr?start=-4096" | ||
| }, | ||
| "memoryMetrics" : { | ||
| "usedOnHeapStorageMemory" : 0, | ||
| "usedOffHeapStorageMemory" : 0, | ||
| "totalOnHeapStorageMemory" : 97832140, | ||
| "totalOffHeapStorageMemory" : 0 | ||
| }, | ||
| "blacklistedInStages" : [ ], | ||
| "attributes" : { } | ||
| } ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it ever possible that multiple collectors are considered young generation (or old generation)? If so, you'd want to use
+=here.I'm not sure if there is a configuration where that might happen, but I'm also not super familiar with all variants here. @kiszk maybe you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, one collector per generation is supported only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late. I agree with one collector per generation.