Skip to content

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

In the dev list, we can still discuss whether the next version is 2.5.0 or 3.0.0. Let us first bump the master branch version to 2.5.0-SNAPSHOT.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @yhuai @rxin @cloud-fan

docs/_config.yml Outdated
SPARK_VERSION: 2.4.0-SNAPSHOT
SPARK_VERSION_SHORT: 2.4.0
SPARK_VERSION: 2.5.0-SNAPSHOT
SPARK_VERSION_SHORT: 2.5.0-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5.0-SNAPSHOT -> 2.5.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@SparkQA
Copy link

SparkQA commented Sep 15, 2018

Test build #96088 has finished for PR 22426 at commit e0187f7.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 15, 2018

Test build #96087 has finished for PR 22426 at commit 640b003.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -1202,6 +1206,7 @@ object MimaExcludes {
}

def excludes(version: String) = version match {
case v if v.startsWith("2.5") => v25excludes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update MimaBuild.scala in this PR together?

val previousSparkVersion = "2.2.0"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be addressed in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I got it, @gatorsmile . Thanks.

@SparkQA
Copy link

SparkQA commented Sep 15, 2018

Test build #96094 has finished for PR 22426 at commit 0389ac1.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

This reverts commit 0389ac1
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we definitely need to bump it; I kind of thought we were moving to 3.0? but doesn't hurt to make this change now.

@SparkQA
Copy link

SparkQA commented Sep 15, 2018

Test build #96095 has finished for PR 22426 at commit ee760b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Thanks! Merged to master.

@asfgit asfgit closed this in bb2f069 Sep 15, 2018
@dongjoon-hyun
Copy link
Member

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants