-
Notifications
You must be signed in to change notification settings - Fork 28.8k
[SPARK-25436] Bump master branch version to 2.5.0-SNAPSHOT #22426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/_config.yml
Outdated
SPARK_VERSION: 2.4.0-SNAPSHOT | ||
SPARK_VERSION_SHORT: 2.4.0 | ||
SPARK_VERSION: 2.5.0-SNAPSHOT | ||
SPARK_VERSION_SHORT: 2.5.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.5.0-SNAPSHOT -> 2.5.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Test build #96088 has finished for PR 22426 at commit
|
Test build #96087 has finished for PR 22426 at commit
|
@@ -1202,6 +1206,7 @@ object MimaExcludes { | |||
} | |||
|
|||
def excludes(version: String) = version match { | |||
case v if v.startsWith("2.5") => v25excludes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update MimaBuild.scala in this PR together?
val previousSparkVersion = "2.2.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be addressed in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I got it, @gatorsmile . Thanks.
Test build #96094 has finished for PR 22426 at commit
|
This reverts commit 0389ac1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we definitely need to bump it; I kind of thought we were moving to 3.0? but doesn't hurt to make this change now.
Test build #96095 has finished for PR 22426 at commit
|
Thanks! Merged to master. |
+1, LGTM. |
What changes were proposed in this pull request?
In the dev list, we can still discuss whether the next version is 2.5.0 or 3.0.0. Let us first bump the master branch version to
2.5.0-SNAPSHOT
.How was this patch tested?
N/A