[SPARK-24275][SQL] Revise doc comments in InputPartition #21326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #90620 has finished for PR 21326 at commit
|
cloud-fan
reviewed
May 15, 2018
| * Note that if a host name cannot be recognized by Spark, it will be ignored as it was not in | ||
| * the returned locations. By default this method returns empty string array, which means this | ||
| * task has no location preference. | ||
| * data reader has no location preference. |
Contributor
There was a problem hiding this comment.
or this input partition's reader
Contributor
|
lgtm except one comment |
|
Test build #90649 has finished for PR 21326 at commit
|
|
Test build #90650 has finished for PR 21326 at commit
|
Contributor
|
thanks, merging to master! |
rdblue
reviewed
May 21, 2018
| * Returns a list of read tasks. Each task is responsible for creating a data reader to | ||
| * output data for one RDD partition. That means the number of tasks returned here is same as | ||
| * the number of RDD partitions this scan outputs. | ||
| * Returns a list of {@link InputPartition}s. Each {@link InputPartition} is responsible for |
Contributor
There was a problem hiding this comment.
Nit: Instead of {@link InputPartition}s use {@link InputPartition partitions} to add the plural. That avoids awkward formatting and links that are missing 's'.
Contributor
|
Belated +1. In the future, I think it is better for readable docs to pluralize linked terms as I suggested in a comment. |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Mar 7, 2019
## What changes were proposed in this pull request? In apache#21145, DataReaderFactory is renamed to InputPartition. This PR is to revise wording in the comments to make it more clear. ## How was this patch tested? None Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21326 from gengliangwang/revise_reader_comments. (cherry picked from commit 6fb7d6c)
rdblue
pushed a commit
to rdblue/spark
that referenced
this pull request
Apr 3, 2019
## What changes were proposed in this pull request? In apache#21145, DataReaderFactory is renamed to InputPartition. This PR is to revise wording in the comments to make it more clear. ## How was this patch tested? None Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21326 from gengliangwang/revise_reader_comments.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Oct 15, 2019
## What changes were proposed in this pull request? In apache#21145, DataReaderFactory is renamed to InputPartition. This PR is to revise wording in the comments to make it more clear. ## How was this patch tested? None Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21326 from gengliangwang/revise_reader_comments. (cherry picked from commit 6fb7d6c)
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
In apache#21145, DataReaderFactory is renamed to InputPartition. This PR is to revise wording in the comments to make it more clear. None Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21326 from gengliangwang/revise_reader_comments. Ref: LIHADOOP-48531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #21145, DataReaderFactory is renamed to InputPartition.
This PR is to revise wording in the comments to make it more clear.
How was this patch tested?
None