Skip to content

[SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually test [desc|acs]_nulls_[first|last] functions in PySpark #21035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

There was a mistake in tests.py missing assertEquals.

How was this patch tested?

Fixed tests.

@HyukjinKwon
Copy link
Member Author

cc @ueshin, could you take a look when you are available?

@HyukjinKwon HyukjinKwon changed the title [SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually test [desc|acs]_nulls_[first|last] functions [SPARK-23847][FOLLOWUP][PYTHON][SQL] Actually test [desc|acs]_nulls_[first|last] functions in PySpark Apr 11, 2018
@SparkQA
Copy link

SparkQA commented Apr 11, 2018

Test build #89166 has finished for PR 21035 at commit ffa05dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Merged to master.

Thanks @felixcheung.

@asfgit asfgit closed this in c7622be Apr 11, 2018
@HyukjinKwon HyukjinKwon deleted the SPARK-23847 branch October 16, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants