[SPARK-23893][Core][SQL] Avoid possible integer overflow in multiplication #21002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR avoids possible overflow at an operation
long = (long)(int * int)
. The multiplication of large positive integer values may set one to MSB. This leads to a negative value in long while we expected a positive value (e.g.0111_0000_0000_0000 * 0000_0000_0000_0010
).This PR performs long cast before the multiplication to avoid this situation.
How was this patch tested?
Existing UTs