[SPARK-23424][SQL]Add codegenStageId in comment#20612
Closed
kiszk wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-23424][SQL]Add codegenStageId in comment#20612kiszk wants to merge 2 commits intoapache:masterfrom
kiszk wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #87452 has finished for PR 20612 at commit
|
Member
Author
|
ping @gatorsmile, @rednaxelafx |
Contributor
|
LGTM. Let's wait for one more LGTM from @gatorsmile / @cloud-fan . |
cloud-fan
reviewed
Feb 20, 2018
| val name = freshName("c") | ||
| if (force || | ||
| SparkEnv.get != null && SparkEnv.get.conf.getBoolean("spark.sql.codegen.comments", false)) { | ||
| val name = if (placeholderId != "") placeholderId else freshName("c") |
Contributor
There was a problem hiding this comment.
although the caller should guarantee placeholderId is unique, shall we add a check here for safe? e.g. assert(!placeHolderToComments.containsKey("placeholderId"))
Contributor
|
LGTM |
|
Test build #87555 has finished for PR 20612 at commit
|
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR always adds
codegenStageIdin comment of the generated class. This is a replication of #20419 for post-Spark 2.3.Closes #20419
How was this patch tested?
Existing tests