[SPARK-23421] [SQL] Document the behavior change in SPARK-22356 #20606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
|
Test build #87442 has finished for PR 20606 at commit
|
|
Retest this please |
|
Test build #87448 has finished for PR 20606 at commit
|
| @@ -195,7 +195,7 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils { | |||
|
|
|||
| object PROCESS_TABLES extends QueryTest with SQLTestUtils { | |||
| // Tests the latest version of every release line. | |||
| val testingVersions = Seq("2.0.2", "2.1.2", "2.2.0") | |||
| val testingVersions = Seq("2.0.2", "2.1.2", "2.2.0", "2.2.1") | |||
There was a problem hiding this comment.
Please don't mix this into a PR with title Document.
There was a problem hiding this comment.
This is to verify what we explained in doc is correct.
There was a problem hiding this comment.
Yep. Please update the title to include that, too.
There was a problem hiding this comment.
Already has it in the PR description.
There was a problem hiding this comment.
The main goal of this PR is not to test it but to document it. We need another backport PR to SPARK 2.2 without the test.
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Feb 15, 2018
## What changes were proposed in this pull request? #19579 introduces a behavior change. We need to document it in the migration guide. ## How was this patch tested? Also update the HiveExternalCatalogVersionsSuite to verify it. Author: gatorsmile <gatorsmile@gmail.com> Closes #20606 from gatorsmile/addMigrationGuide. (cherry picked from commit a77ebb0) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
|
Thanks! Merged to master/2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#19579 introduces a behavior change. We need to document it in the migration guide.
How was this patch tested?
Also update the HiveExternalCatalogVersionsSuite to verify it.