Skip to content

[SPARK-21860][CORE][FOLLOWUP] fix java style error #20558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgaido91
Copy link
Contributor

@mgaido91 mgaido91 commented Feb 9, 2018

What changes were proposed in this pull request?

#19077 introduced a Java style error (too long line). Quick fix.

How was this patch tested?

running ./dev/lint-java

@mgaido91
Copy link
Contributor Author

mgaido91 commented Feb 9, 2018

cc @10110346 @cloud-fan

@cloud-fan
Copy link
Contributor

LGTM, thanks! We should run java-style-check in PR builder eventually...

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we should better fix them once in batch right before an RC is out ...

@SparkQA
Copy link

SparkQA commented Feb 9, 2018

Test build #87257 has finished for PR 20558 at commit 3f57f91.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Feb 9, 2018

Merged to master.
(Agree @HyukjinKwon but this one only affects master)

@asfgit asfgit closed this in 0fc2631 Feb 9, 2018
robert3005 pushed a commit to palantir/spark that referenced this pull request Feb 12, 2018
## What changes were proposed in this pull request?

apache#19077 introduced a Java style error (too long line). Quick fix.

## How was this patch tested?

running `./dev/lint-java`

Author: Marco Gaido <marcogaido91@gmail.com>

Closes apache#20558 from mgaido91/SPARK-21860.
zzcclp added a commit to zzcclp/spark that referenced this pull request Sep 20, 2019
PR-apache#19077 introduced a Java style error (too long line). Quick fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants