Skip to content

[SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala #20354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala #20354

wants to merge 1 commit into from

Conversation

BryanCutler
Copy link
Member

What changes were proposed in this pull request?

This syncs the ML Python API with Scala for differences found after the 2.3 QA audit.

How was this patch tested?

NA

@BryanCutler
Copy link
Member Author

@holdenk @MLnick , just found some minor doc differences between python and scala during the audit for 2.3

@SparkQA
Copy link

SparkQA commented Jan 22, 2018

Test build #86498 has finished for PR 20354 at commit 46f354b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

MLnick
MLnick approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@MLnick MLnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not sure if we will merge this into branch-2.3 as RC2 has been cut. Let's wait a bit and see.

felixcheung
felixcheung approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I guess they are not blockers, but we should probably merge to branch-2.3?

@holdenk
Copy link
Contributor

holdenk commented Jan 24, 2018

I'd say branch-2.3 since we want the fix in 2.3.1 even if it isn't in 2.3.0.

@felixcheung
Copy link
Member

merged to master/2.3

asfgit pushed a commit that referenced this pull request Jan 25, 2018
@BryanCutler
[SPARK-23163][DOC][PYTHON] Sync ML Python API with Scala
e66c66c 
## What changes were proposed in this pull request?

This syncs the ML Python API with Scala for differences found after the 2.3 QA audit.

## How was this patch tested?

NA

Author: Bryan Cutler <cutlerb@gmail.com>

Closes #20354 from BryanCutler/pyspark-ml-doc-sync-23163.

(cherry picked from commit 39ee2ac)
Signed-off-by: Felix Cheung <felixcheung@apache.org>
@asfgit asfgit closed this in 39ee2ac Jan 25, 2018
@BryanCutler
Copy link
Member Author

Thanks @felixcheung and others for reviewing!

@BryanCutler BryanCutler deleted the pyspark-ml-doc-sync-23163 branch March 6, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MLnick MLnick MLnick approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BryanCutler @SparkQA @holdenk @felixcheung @MLnick